Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0870 A proposal for a type trait to detect narrowing conversions #724

Open
wg21bot opened this issue Jan 18, 2020 · 36 comments
Open

P0870 A proposal for a type trait to detect narrowing conversions #724

wg21bot opened this issue Jan 18, 2020 · 36 comments
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 C++26 Targeted at C++26 IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review size - small paper size estimate

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Jan 18, 2020

P0870R1 A proposal for a type trait to detect narrowing conversions (Giuseppe D'Angelo)

@wg21bot wg21bot added the LEWGI Library Evolution Incubator label Jan 18, 2020
@wg21bot wg21bot added this to the 2020-02 milestone Jan 18, 2020
@jfbastien jfbastien added the EWGI Evolution Incubator label Feb 11, 2020
@theres-waldo theres-waldo added this to Thursday PM in EWG-I Prague Feb 11, 2020
@theres-waldo theres-waldo moved this from Thursday PM to Wednesday PM in EWG-I Prague Feb 12, 2020
@erichkeane
Copy link
Collaborator

EWG-I in Prague

Forward D0870R2 to EWG, as we believe that EWGI cannot provide any further useful feedback to the author.

SF F N A SA
5 4 0 0 0

@erichkeane erichkeane added EWG Evolution and removed EWGI Evolution Incubator labels Feb 12, 2020
@jfbastien jfbastien removed the LEWGI Library Evolution Incubator label Feb 13, 2020
@jfbastien jfbastien added this to Friday in EWG Prague Feb 13, 2020
@jfbastien
Copy link
Collaborator

EWG Prague Friday afternoon:

D0870R2 A proposal for a type trait to detect narrowing conversions

Send to SG6 Numerics for input.

SF F N A SA
4 4 6 3 0

We have no concerns with this, only send this paper back to us if SG6 or LEWG / LWG / CWG ask.

SF F N A SA
3 13 2 0 0

@jfbastien jfbastien added SG6 Numerics LEWG Library Evolution and removed EWG Evolution labels Feb 14, 2020
@brycelelbach
Copy link

brycelelbach commented Feb 18, 2020

Prague 2020-02 LEWGI Minutes

P0870R1 std::is_narrowing_conversion: Direction Review

Chair: Billy Baker

Champion: Marc Mutz

Minute Taker: David Olsen

Start Review: 2020-02-11 08:39

You mentioned that there are proposed changes to what are narrowing conversions in flight? Do we expect the definition to change again in the future?

Does EWG(I) need to see this?

Start Polling: 9:14

POLL: We should promise more committee time to pursuing P0870, knowing that our time is scarce and this will leave less time for other work.

Strongly For Weakly For Neutral Weakly Against Strongly Against
2 10 2 1 0

Attendance: 20

# of Authors: 1

Author Position: SF

End: 9:16

CONSENSUS: Bring a revision of P0870R1 (std::is_narrowing_conversion) to EWGI for review, and then revise, with the guidance below, and return to LEWGI for further design review.

  • Paper authors are encouraged to provide a better example of an implementation.
  • Paper authors are encouraged to provide a revision history.
  • Paper authors are encouraged to provide additional references in P0870 to papers related to narrowing conversions that were mentioned during the discussion such as P1818.

@brycelelbach brycelelbach added LEWGI Library Evolution Incubator needs-revision Paper needs changes before it can proceed and removed LEWG Library Evolution labels Feb 18, 2020
@jensmaurer jensmaurer removed this from the 2020-02 milestone Feb 18, 2020
@wg21bot
Copy link
Collaborator Author

wg21bot commented Apr 24, 2020

P0870R2 A proposal for a type trait to detect narrowing conversions (Giuseppe D'Angelo)

@wg21bot wg21bot added this to the 2020-telecon milestone Apr 24, 2020
@jfbastien jfbastien removed the needs-revision Paper needs changes before it can proceed label Apr 24, 2020
@wg21bot
Copy link
Collaborator Author

wg21bot commented May 21, 2020

P0870R3 A proposal for a type trait to detect narrowing conversions (Giuseppe D'Angelo)

@cor3ntin cor3ntin added this to Mailing List Discussion Queue in Library Evolution Telecons Aug 4, 2020
@brycelelbach brycelelbach added LEWG Library Evolution B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 TS Ship vehicle: TS numerics-ts-1 and removed LEWGI Library Evolution Incubator labels Aug 25, 2020
@brycelelbach brycelelbach added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Sep 23, 2022
@brycelelbach brycelelbach added LWG Library and removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Nov 8, 2022
@cor3ntin
Copy link

cor3ntin commented Nov 8, 2022

2022-10 Library Evolution Electronic Poll Outcomes

Send [P0870R4] is_convertible_without_narrowing to Library Working Group for C++26, classified as an addition ([P0592R4] bucket 3 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
9 6 1 0 0

Outcome: Strong consensus in favor.

@dangelog
Copy link

dangelog commented Nov 9, 2022

@cor3ntin I believe the above is a C&P mistake? I've got 9/6/1/0/0 (the outcomes paper isn't published yet, so I can't check against an authoritative reference...)

@cor3ntin
Copy link

cor3ntin commented Nov 9, 2022

Indeed, thanks for noticing.

@wg21bot
Copy link
Collaborator Author

wg21bot commented Feb 20, 2023

P0870R5 A proposal for a type trait to detect narrowing conversions (Giuseppe D'Angelo)

@cplusplus cplusplus deleted a comment from wg21bot Feb 20, 2023
@cplusplus cplusplus deleted a comment from wg21bot Feb 20, 2023
@cplusplus cplusplus deleted a comment from wg21bot Feb 20, 2023
@dangelog
Copy link

dangelog commented Mar 7, 2023

Hi @brycelelbach @cor3ntin ; during the review of this paper in Issaquah it's been requested whether LEWG could confirm a design choice.

To this end, I've uploaded R5. It does not change any design / behavior from R4, but it adds a paragraph that elaborates on the design choice mentioned above: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2023/p0870r5.html#ch5.9

I guess this paper should go back to LWG only if LEWG can confirm that the choice was the intended one.

@brycelelbach brycelelbach added LEWG Library Evolution ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting and removed LWG Library labels May 26, 2023
@brycelelbach
Copy link

This paper is now in the custody of Library Evolution.

@brycelelbach
Copy link

@inbal2l and @cor3ntin this can be handled with a mailing list review. It should get higher priority than others, as it's just a design clarification.

@brycelelbach brycelelbach added ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Jun 8, 2023
@inbal2l inbal2l added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Oct 23, 2023
@inbal2l
Copy link
Collaborator

inbal2l commented Dec 19, 2023

As P2280 was approved for C++26, the author would like to make design adjustments accordingly.
P0870R6 will be seen by LEWG when published.

@cor3ntin cor3ntin added needs-revision Paper needs changes before it can proceed and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Jan 10, 2024
@inbal2l
Copy link
Collaborator

inbal2l commented Feb 16, 2024

P3146 (#1797) Proposes a change to support this paper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 C++26 Targeted at C++26 IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review size - small paper size estimate
Projects
Status: No status
Development

No branches or pull requests