Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P0448 A strstream replacement using span<charT> as buffer #103

Closed
jensmaurer opened this issue Jan 26, 2019 · 11 comments · Fixed by cplusplus/draft#4687
Closed

P0448 A strstream replacement using span<charT> as buffer #103

jensmaurer opened this issue Jan 26, 2019 · 11 comments · Fixed by cplusplus/draft#4687
Labels
C++23 Targeted at C++23 LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - large paper size estimate
Milestone
2021-telecon

Comments

@jensmaurer
Copy link
Member

jensmaurer commented Jan 26, 2019 •
edited

P0448R2 A strstream replacement using span<charT> as buffer (Peter Sommerlad)

https://issues.isocpp.org/show_bug.cgi?id=242
@jensmaurer jensmaurer added this to the 2019-02 milestone Jan 26, 2019
@jensmaurer jensmaurer added LEWG Library Evolution LWG Library labels Jan 26, 2019
@jensmaurer jensmaurer changed the title P0448 A strstream replacement using span&lt;charT&gt; as buffer P0448 A strstream replacement using span<charT> as buffer Jan 27, 2019
@jensmaurer
Copy link
Member Author

Quote from the paper: "There was email discussion (Alisdair, Marshall, Titus and library mailing list) on semantics of move, timing and wording of strstream removal. Therefore, this paper needs to be reconsidered with that design respect by LEWG."

@jensmaurer jensmaurer removed the LWG Library label Jan 28, 2019
@PeterSommerlad
Copy link

PeterSommerlad commented Feb 4, 2019 •
edited by jensmaurer

To be discussed in LEWG (from the paper):

  • Should we keep a separate header <spanstream> ? Where to put it instead?
  • Is adding a default constructor for basic_spanbuf OK?

strstream removal is now in a separate paper P1410 Remove deprecated strstream #195 that can be considered after P0408 Efficient Access to basic_stringbuf's Buffer #100 and P0448 A strstream replacement using span as buffer #103 have been moved to the WP.

move semantics: clean up of moved-from basic_spanbuf is now implementation-defined (my suggestion):
"It is implementation-defined wether rhs.buf.empty() returns true after the move."

@tituswinters
Copy link

tituswinters commented Feb 22, 2019 •
edited by jensmaurer

LEWG in Kona:
If we default construct a spanbuf, can it default construct a span?
Unanimous approval - renders the type regular.

Should we keep the header ?
Unanimous approval for

Send to LWG for C++20.
Unanimous consent.

@tituswinters tituswinters added LWG Library and removed LEWG Library Evolution labels Feb 22, 2019
@jensmaurer jensmaurer modified the milestones: 2019-02, 2019-07 Mar 21, 2019
@mclow mclow added the C++20 Targeted at C++20 label Jul 8, 2019
@mclow mclow added the needs-revision Paper needs changes before it can proceed label Jul 17, 2019
@cplusplus cplusplus deleted a comment from PeterSommerlad Jul 18, 2019
@cplusplus cplusplus deleted a comment from PeterSommerlad Jul 18, 2019
@mclow mclow removed the needs-revision Paper needs changes before it can proceed label Jul 18, 2019
@jensmaurer jensmaurer modified the milestones: 2019-07, 2019-11 Aug 23, 2019
@mclow mclow removed the C++20 Targeted at C++20 label Nov 3, 2019
@mclow
Copy link

mclow commented Nov 3, 2019

This was not adopted for C++20. Removing the "C++20" label.

@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-06 Feb 18, 2020
@JeffGarland JeffGarland added the lwg-prereview Needs LWG initial review before full group label Jul 13, 2020
@JeffGarland JeffGarland added the B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 label Sep 3, 2020
@ben-craig ben-craig added the size - large paper size estimate label Oct 17, 2020
@JeffGarland JeffGarland added lwg-fullreview Paper is ready for lwg full group review and removed lwg-prereview Needs LWG initial review before full group labels Dec 4, 2020
@JeffGarland
Copy link
Member

LWG held a first review of the paper on 2020-12-04 and asked for some updates. Will re-review after changes are made.

https://wiki.edg.com/bin/view/Wg21fall2020/P0448-2020-12-04

@jensmaurer jensmaurer removed this from the 2020-telecon milestone Dec 28, 2020
@jensmaurer jensmaurer added this to the 2021-telecon milestone Dec 28, 2020
@brycelelbach brycelelbach added LEWG Library Evolution ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting C++23 Targeted at C++23 scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed LWG Library labels Feb 13, 2021
@billy-baker
Copy link
Collaborator

billy-baker commented Feb 16, 2021 •
edited by brycelelbach

2021-02-16 Library Evolution Telecon

D0448R3: spanstream

2021-02-16 Library Evolution Telecon Minutes

POLL: basic_ispanstream should be usable with read-only sequences (span) as shown in section 6.4 of D0448R3 (B3).

Attendance: 28

# of Authors: 1

Outcome:
Unanimous in favor of making basic_ispanstream usable with read-only sequences as shown in section 6.4 of D0448R3.

Outcome

The author shall publish D0448R3 as written and seen by Library Evolution today.

Library Evolution sends D0448R3 (spanstream), revised to make basic_ispanstream usable with read-only sequences (span), to LWG, for C++23, classified as new work (P0592 bucket 3 item).

@JeffGarland
Copy link
Member

LWG reviewed 2021-02-19 in telecon

https://wiki.edg.com/bin/view/Wg21telecons2021/P0448-20210219

Will reschedule when updates are complete

@JeffGarland JeffGarland added LWG Library needs-revision Paper needs changes before it can proceed labels Feb 19, 2021
@brycelelbach brycelelbach removed LEWG Library Evolution ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Feb 19, 2021
@wg21bot
Copy link
Collaborator

wg21bot commented Feb 22, 2021

P0448R3 A strstream replacement using span as buffer (Peter Sommerlad)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Feb 22, 2021
@JeffGarland
Copy link
Member

JeffGarland commented Feb 26, 2021 •
edited

R4 reviewed 2021-02-26 Telecom. Approved for c++23

https://wiki.edg.com/bin/view/Wg21telecons2021/P0448-20210226

F A N
11 0 0

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed lwg-fullreview Paper is ready for lwg full group review B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 labels Feb 26, 2021
@wg21bot
Copy link
Collaborator

wg21bot commented Mar 25, 2021

P0448R4 A strstream replacement using span as buffer (Peter Sommerlad)

@jensmaurer jensmaurer mentioned this issue Jun 3, 2021
Closed
@cor3ntin cor3ntin added plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. and removed tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. labels Jun 7, 2021
@jensmaurer jensmaurer mentioned this issue Jun 11, 2021
Merged
@wg21bot
Copy link
Collaborator

wg21bot commented Oct 26, 2021

Adopted 2021-06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - large paper size estimate
Projects
None yet
Milestone
2021-telecon
Development

Successfully merging a pull request may close this issue.

P0448R4 A strstream replacement using span<charT> as buffer cplusplus/draft
10 participants
@mclow @brycelelbach @ben-craig @cor3ntin @PeterSommerlad @JeffGarland @tituswinters @billy-baker @jensmaurer @wg21bot