Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P0952 R2 A new specification for std::generate_canonical #574

Closed
wg21bot opened this issue Aug 9, 2019 · 11 comments · Fixed by cplusplus/draft#6690
Closed

P0952 R2 A new specification for std::generate_canonical #574

wg21bot opened this issue Aug 9, 2019 · 11 comments · Fixed by cplusplus/draft#6690
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote.
Milestone

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Aug 9, 2019

P0952R0 A new specification for std::generate_canonical (Thomas Köppe, Davis Herring)

@wg21bot wg21bot added this to the 2019-11 milestone Aug 9, 2019
@wg21bot wg21bot added LWG Library SG6 Numerics labels Aug 9, 2019
@jensmaurer jensmaurer removed the LWG Library label Aug 9, 2019
@Cpp-Lisa
Copy link
Collaborator

Cpp-Lisa commented Nov 4, 2019

Removing SG6, adding LWG

@Cpp-Lisa Cpp-Lisa added LWG Library and removed SG6 Numerics labels Nov 4, 2019
@opensdh
Copy link

opensdh commented Nov 25, 2019

SG6 brought up a question for LEWG here about a separate bug.

@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-02 Dec 22, 2019
@jensmaurer jensmaurer added the LEWG Library Evolution label Dec 22, 2019
@jensmaurer jensmaurer removed the LWG Library label Jan 18, 2020
@brycelelbach brycelelbach added the needs-revision Paper needs changes before it can proceed label May 10, 2020
@brycelelbach
Copy link

SG6 brought up a question for LEWG here about a separate bug.

We need to know what decisions Library Evolution needs to make here; this is unclear to me from the paper. Whatever question came up in SG6 needs to be clearly defined.

@brycelelbach
Copy link

The authors have identified the questions for Library Evolution.

Is generate_canonical's second template parameter really meant to be "bits" or should it be "digits in the radix of the floating-point type in question" (as would be consistent with the "numeric_limits<RealType>::digits" used in conjunction with it).

@brycelelbach brycelelbach removed the needs-revision Paper needs changes before it can proceed label May 11, 2020
@brycelelbach brycelelbach added this to Weekly Mailing List Discussions in Library Evolution Telecons May 11, 2020
@cor3ntin
Copy link

cor3ntin commented Jul 13, 2020

LEWG Mailing list review, 2020-07

We didn't have sufficient participation to be very affirmative about anything, but there is some agreement that generate_canonical's second template parameter should be "bits"However, there are some concerns about the definition of the function and its inherent bias, and lack of uniformity.We will defer to SG-6 to answer these questions.

Sending to SG6

@cor3ntin cor3ntin added SG6 Numerics and removed LEWG Library Evolution labels Jul 13, 2020
@cor3ntin cor3ntin removed this from Weekly Mailing List Discussions in Library Evolution Telecons Jul 13, 2020
@cplusplus cplusplus deleted a comment from tahonermann Oct 20, 2020
@brycelelbach brycelelbach added B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 IS Ship vehicle: IS labels Oct 20, 2020
@jensmaurer jensmaurer modified the milestones: 2020-02, 2021-telecon Dec 28, 2020
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@mattkretz
Copy link
Collaborator

mattkretz commented May 2, 2022

P0952R0: A new specification for std::generate_canonical

2022-03-17 SG6 Telecon Minutes

Chair: Matthias Kretz

Champion: Thomas Köppe and Davis Herring

Minute Taker: Dietmar Kühl

Summary

The main question from LWG to LEWG, how to interpret the second template parameter, was deferred from LEWG to SG6. SG6 made a unanimous decision to interpret the template parameter as digits in the floating-point radix. SG6 discussed a few more details of the paper but did not request any changes.

Polls

POLL: The second template argument for generate_canonical should be interpreted as a number of digits in the floating-point radix.

No objections to unanimous consent.

# of Authors: 2
# of Participants: 8

POLL: Deprecate generate_canonical.

F N A
1 4 3

# of Authors: 2
# of Participants: 8
Outcome: no consent
Comments: First merge the functionality into something else, then consider deprecation.

POLL: Let generate_canonical produce a member of an arithmetic progression of floats with equal probability.

No objections to unanimous consent.

# of Authors: 2
# of Participants: 8

POLL: Choosing a member of the arithmetic progression is QoI.

SF F N A SA
0 1 2 4 1

# of Authors: 2
# of Participants: 8
Outcome: no consent

POLL: Instruct the author to apply the bits/digits wording change and send a revision with wording of the paper to LWG.

No objections to unanimous consent.

# of Authors: 2
# of Participants: 8

@mattkretz mattkretz added LWG Library needs-revision Paper needs changes before it can proceed and removed SG6 Numerics labels May 2, 2022
@jensmaurer jensmaurer removed this from the 2022-telecon milestone Jan 25, 2023
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 16, 2023

P0952R1 A new specification for std::generate_canonical (Thomas Koeppe)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Oct 16, 2023
@wg21bot wg21bot added this to the 2023-telecon milestone Oct 16, 2023
@wg21bot wg21bot changed the title P0952 A new specification for std::generate_canonical P0952 R1 A new specification for std::generate_canonical Oct 16, 2023
@JeffGarland
Copy link
Member

JeffGarland commented Nov 11, 2023

Notes: https://wiki.edg.com/bin/view/Wg21kona2023/LibraryWorkingGroup

Poll: Set LWG2524 to tentatively ready by adopting P0952r2?

|F|A|N|
|10|0|0|

LWG 2023-11-10: Approved for plenary straw polls in Kona.

@JeffGarland JeffGarland added the tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. label Nov 11, 2023
@inbal2l inbal2l added plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. and removed tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. labels Dec 17, 2023
@wg21bot
Copy link
Collaborator Author

wg21bot commented Dec 19, 2023

P0952R2 A new specification for std::generate_canonical (Thomas Köppe, Davis Herring)

@wg21bot wg21bot changed the title P0952 R1 A new specification for std::generate_canonical P0952 R2 A new specification for std::generate_canonical Dec 19, 2023
@opensdh
Copy link

opensdh commented Apr 1, 2024

@JeffGarland: LWG2524 still shows as Open.

@jwakely
Copy link
Member

jwakely commented Apr 2, 2024

@JeffGarland: LWG2524 still shows as Open.

I've closed it as Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants