Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1083 Move resource_adaptor from Library TS to the C++ WP #33

Open
jensmaurer opened this issue Jan 5, 2019 · 12 comments
Open

P1083 Move resource_adaptor from Library TS to the C++ WP #33

jensmaurer opened this issue Jan 5, 2019 · 12 comments
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 C++26 Targeted at C++26 IS Ship vehicle: IS LWG Library size - medium paper size estimate
Projects
LWG in Kona 2019
Milestone
2024-telecon

Comments

@jensmaurer
Copy link
Member

jensmaurer commented Jan 5, 2019 •
edited

P1083R2 Move resource_adaptor from Library TS to the C++ WP (Pablo Halpern)

https://issues.isocpp.org/show_bug.cgi?id=466
@jensmaurer jensmaurer added this to the 2019-02 milestone Jan 5, 2019
@jensmaurer jensmaurer added the LWG Library label Jan 5, 2019
@jensmaurer jensmaurer added this to Friday in LWG in Kona 2019 Feb 5, 2019
@mclow mclow added the needs-revision Paper needs changes before it can proceed label Feb 23, 2019
@mclow
Copy link

mclow commented Feb 23, 2019 •
edited by jensmaurer

Reviewed on Friday in LWG in Kona; needs an update

@jensmaurer jensmaurer modified the milestones: 2019-02, 2019-07 Mar 21, 2019
@wg21bot
Copy link
Collaborator

wg21bot commented Jun 23, 2019

P1083R3 Move resource_adaptor from Library TS to the C++ WP (Pablo Halpern)

@wg21bot wg21bot added this to the 2019-07 milestone Jun 23, 2019
@jensmaurer jensmaurer removed the needs-revision Paper needs changes before it can proceed label Jun 27, 2019
@mclow mclow added the C++20 Targeted at C++20 label Jul 8, 2019
MrAnno added a commit to MrAnno/folly that referenced this issue Aug 23, 2019
@MrAnno
Fix sorted_vector PMR test cases
10e5a45 
folly::detail::std_pmr uses either std::pmr or std::experimental::pmr.

Polymorphic Memory Resources has been standardized in C++17, but
pmr::resource_adaptor was left behind
(cplusplus/papers#33), which means
resource_adaptor is not available when a C++17 ready standard library is
detected by folly.

This commit reimplements test_resource without using the non-standard
adaptor.
@MrAnno MrAnno mentioned this issue Aug 23, 2019
Closed
@jensmaurer jensmaurer modified the milestones: 2019-07, 2019-11 Aug 23, 2019
facebook-github-bot pushed a commit to facebook/folly that referenced this issue Aug 26, 2019
@MrAnno @facebook-github-bot
Fix sorted_vector PMR test cases (#1207)
74f346e 
Summary:
`folly::detail::std_pmr` uses either `std::pmr` or `std::experimental::pmr`.

"Polymorphic Memory Resources" has been standardized in C++17, but `pmr::resource_adaptor` was [left behind](cplusplus/papers#33), which means `resource_adaptor` is not available when a C++17 ready standard library is detected by folly.

This commit reimplements `test_resource` without using the non-standard adaptor.

```
folly/test/sorted_vector_test.cpp:862:31: error: ‘folly::detail::std_pmr::resource_adaptor’ has not been declared
  862 | using folly::detail::std_pmr::resource_adaptor;
      |                               ^~~~~~~~~~~~~~~~
```
Pull Request resolved: #1207

Reviewed By: nbronson

Differential Revision: D17003049

Pulled By: yfeldblum

fbshipit-source-id: 7bcd5b4bb4368366cd57d89b9ef88deaaff808d6
@mclow mclow removed the C++20 Targeted at C++20 label Nov 3, 2019
@mclow
Copy link

mclow commented Nov 3, 2019

This was not adopted for C++20. Removing the "C++20" label.

@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-06 Feb 18, 2020
@ben-craig ben-craig added B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 size - small paper size estimate labels Oct 17, 2020
@jensmaurer jensmaurer modified the milestones: 2020-telecon, 2021-telecon Dec 28, 2020
@JeffGarland JeffGarland added IS Ship vehicle: IS lwg-pending LWG Chair needs to disposition labels Sep 18, 2021
@JeffGarland
Copy link
Member

LWG reviewed this paper on 2021-11-05 and found several design related questions that need to be answered before this can move forward.

https://wiki.edg.com/bin/view/Wg21telecons2021/P1083-20211105

@JeffGarland JeffGarland added needs-revision Paper needs changes before it can proceed and removed lwg-pending LWG Chair needs to disposition labels Nov 11, 2021
@cor3ntin cor3ntin added scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Mar 14, 2022
@inbal2l
Copy link
Collaborator

inbal2l commented Mar 19, 2022

Paper was discussed in LEWG on March 15th 2022 (Full Minutes)

2022-03-15 Library Evolution Telecon

P1083R5: Move resource_adaptor from Library TS to the C++ WP

Chair: Inbal Levi

Champion: Pablo Halpern

Minute Taker: Mark Hoemmen

Summary

Discussion about the added facilities in R5 brought up concerns. We'll move forward with the paper without the added facilities. Paper was forwarded for C++26, there was no consensus in the room for forwarding for C++23.

POLL: Forward P1083R5 (Move resource_adaptor from Library TS to the C++ WP) for C++23 with priority 3, with the following changes:

  1. max_align_v should be inline.
  2. Remove nested type from aligned_raw_storage.
  3. Remove aligned_object_storage from the proposal.

(to be approved by LEWG electronic poll)

SF F N A SA
1 4 7 1 1

Attendance: 23

# of Authors: 1

Author Position: SF

Outcome: No consensus

A: Design phase for C++23 is over.

POLL: Forward P1083R5 (Move resource_adaptor from Library TS to the C++ WP) for C++26 with priority 3, with the following changes:

  1. max_align_v should be inline.
  2. Remove nested type from aligned_raw_storage.
  3. Remove aligned_object_storage from the proposal.

(to be approved by LEWG electronic poll)

SF F N A SA
3 6 2 0 1

Attendance: 23

# of Authors: 1

Author Position: SF

Outcome: Consensus in favor

SA: I think the audience for this facility will be infinitesimally small, and it doesn't seem like a huge burden for that audience to provide this facility as a custom nonstandard facility for their particular needs.

Outcome

R5 of the paper, with the changes stated in the poll, was forwarded to electronic polling with priority 3, for C++26.

@inbal2l inbal2l added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll C++26 Targeted at C++26 and removed scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review C++23 Targeted at C++23 labels Mar 19, 2022
@wg21bot
Copy link
Collaborator

wg21bot commented Mar 21, 2022

P1083R5 Move resource_adaptor from Library TS to the C++ WP (Pablo Halpern)

@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Apr 22, 2022
@brycelelbach
Copy link

2022-05 Library Evolution Electronic Poll Outcomes

POLL: Return [P1083R5] resource_adaptor to Library Working Group for C++26, classified as an addition ([P0592R4] bucket 3 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
3 7 1 4 2

No consensus. The paper was not updated to follow Library Evolution guidance, which was the cause of most of the votes against. The authors will be asked to produce a new revision with the requested changes and then we will conduct another vote.

@brycelelbach brycelelbach added needs-revision Paper needs changes before it can proceed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting and removed LWG Library ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jun 19, 2022
@wg21bot
Copy link
Collaborator

wg21bot commented Jul 21, 2022

P1083R6 Move resource_adaptor from Library TS to the C++ WP (Pablo Halpern)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Jul 21, 2022
@brycelelbach brycelelbach added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Aug 3, 2022
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Sep 23, 2022
@wg21bot
Copy link
Collaborator

wg21bot commented Oct 17, 2022

P1083R7 Move resource_adaptor from Library TS to the C++ WP (Pablo Halpern)

@brycelelbach brycelelbach added LWG Library and removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Nov 8, 2022
@cor3ntin
Copy link

cor3ntin commented Nov 8, 2022 •
edited by brycelelbach

2022-10 Library Evolution Electronic Poll Outcomes

Return [P1083R6] resource_adaptor to Library Working Group for C++26, classified as an addition ([P0592R4] bucket 3 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
1 7 1 0 1

Outcome: Consensus in favor.

@jensmaurer jensmaurer modified the milestones: 2023-telecon, 2024-telecon Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 C++26 Targeted at C++26 IS Ship vehicle: IS LWG Library size - medium paper size estimate
Projects
2024 Tokyo LWG Schedule
Status: No status
LWG in Kona 2019
Friday
Milestone
2024-telecon
Development

No branches or pull requests
8 participants
@mclow @brycelelbach @ben-craig @cor3ntin @JeffGarland @inbal2l @jensmaurer @wg21bot