Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1222 A Standard flatset #148

Closed
jensmaurer opened this issue Jan 26, 2019 · 10 comments
Closed

P1222 A Standard flatset #148

jensmaurer opened this issue Jan 26, 2019 · 10 comments
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Milestone

Comments

@jensmaurer
Copy link
Member

P1222R1 A Standard flatset (Zach Laine)

@jensmaurer jensmaurer added this to the 2019-02 milestone Jan 26, 2019
@jensmaurer jensmaurer added LEWG Library Evolution LWG Library and removed LWG Library labels Jan 26, 2019
@jensmaurer jensmaurer added this to Wednesday in LEWG in Kona 2019 Feb 6, 2019
@tituswinters tituswinters added LWG Library and removed LEWG Library Evolution labels Feb 21, 2019
@tituswinters
Copy link

tituswinters commented Feb 21, 2019

LEWG in Kona:
Define the iterator is not the same as the underlying.
SF F N A SA
0 5 3 2 0

Define the iterator is the same as the underlying.
SF F N A SA
0 1 3 7 1

Leave the iterator unspecified wrt. the underlying.
SF F N A SA
2 9 2 0 1

Delete the constructors for flat_set from containers that are not its container_type.
Unanimous consent

Make the above changes, forward to LWG for C++20.
SF F N A SA
0 5 5 1 0

@jensmaurer jensmaurer removed this from Wednesday in LEWG in Kona 2019 Feb 24, 2019
@jensmaurer jensmaurer removed this from the 2019-02 milestone Mar 21, 2019
@wg21bot
Copy link
Collaborator

wg21bot commented Jun 23, 2019

P1222R2 A Standard flat_set (Zach Laine)

@wg21bot wg21bot added this to the 2019-07 milestone Jun 23, 2019
@mclow mclow added the C++20 Targeted at C++20 label Jul 8, 2019
@jensmaurer jensmaurer modified the milestones: 2019-07, 2019-11 Aug 23, 2019
@mclow mclow removed the C++20 Targeted at C++20 label Nov 3, 2019
@mclow
Copy link

mclow commented Nov 3, 2019

This was not adopted for C++20. Removing the "C++20" label.

@JeffGarland JeffGarland added the C++23 Targeted at C++23 label Feb 18, 2020
@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-06 Feb 18, 2020
@jensmaurer jensmaurer added IS Ship vehicle: IS and removed C++23 Targeted at C++23 labels Feb 18, 2020
@JeffGarland JeffGarland added the lwg-prereview Needs LWG initial review before full group label Mar 25, 2020
@ben-craig ben-craig added B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 size - large paper size estimate labels Oct 17, 2020
@jensmaurer jensmaurer modified the milestones: 2020-telecon, 2021-telecon Dec 28, 2020
@JeffGarland JeffGarland added C++23 Targeted at C++23 lwg-fullreview Paper is ready for lwg full group review and removed lwg-prereview Needs LWG initial review before full group labels Sep 18, 2021
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@cor3ntin cor3ntin added ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list needs-revision Paper needs changes before it can proceed labels Apr 18, 2022
@wg21bot
Copy link
Collaborator

wg21bot commented Apr 25, 2022

P1222R3 A Standard flat_set (Zach Laine)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Apr 25, 2022
@inbal2l inbal2l added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Jun 7, 2022
@inbal2l
Copy link
Collaborator

inbal2l commented Jun 7, 2022

  • LEWG reviewed the latest revisions of the papers "D0429R9: A Standard flat_map" & "D1222R4: A Standard flat_set" during 2022-05-31 telecon (as an extra content for spare meeting time) and reaffirmed forwarding them for C++23 (to be confirmed with an electronic poll)
  • Closing LEWG ML motion to forward the papers which started on 2022-05-17

@JeffGarland JeffGarland added the tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. label Jun 17, 2022
@JeffGarland
Copy link
Member

LWG reviewed and approved over multiple sessions:

https://wiki.edg.com/bin/view/Wg21telecons2022/P1222-20220610
https://wiki.edg.com/bin/view/Wg21telecons2022/P1222-20220517

poll: put P1222r4 to added to C++23 (changes to be reviewed by JW/CC)

F A N
11 0 0

@JeffGarland JeffGarland removed lwg-fullreview Paper is ready for lwg full group review size - large paper size estimate labels Jun 17, 2022
@brycelelbach
Copy link

2022-05-31 Library Evolution Telecon

P0429R9: flat_map

2022-05-31 Library Evolution Telecon Minutes

P1222R4: flat_set

2022-05-31 Library Evolution Telecon Minutes

Chair: Bryce Adelstein Lelbach

Minute Taker: Dietmar Kühl

Champion: Zach Laine

Start: 2022-05-31 12:09 Eastern

6 changes that have happened to flat_map/flat_set. None of those are innovations - they are changes made based to be consistent with other papers in flight:

  1. Replacing the explicit comparison operators with spaceship.
  2. Providing erase_if overloads.
  3. Heterogeneous operations.
  4. ranges::to support.
  5. Formatting support.
  6. Removing the redundant from range flat_map constructors.

Does this proposal have:

  • Examples?
    • Yes.
  • Field experience?
    • We believe that a Library implementer has implemented the proposed changes for flat_set.
  • Wording?
    • Yes.

POLL: Return D0429R9 (flat_map) to Library for C++23 classified as B3 - addition (to be confirmed with a Library Evolution electronic poll).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
2 9 0 0 0

Attendance: 21

# of Authors: 1

Author Position: SF

Outcome: Unanimous consensus in favor.

POLL: Return D1222R4 (flat_set) to Library for C++23 classified as B3 - addition (to be confirmed with a Library Evolution electronic poll).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
2 8 0 0 0

Attendance: 21

# of Authors: 1

Author Position: SF

Outcome: Unanimous consensus in favor.

End: 12:30

Summary

We discussed some updates that need to be made to flat_map and flat_set to bring them in line with other proposals in flight.
These updates are not completely new or novel; they're just an extension of other changes that Library Evolution made.
For example, we added heterogeneous overloads to the Standard Library's existing associative containers, so we should add them to flat_set and flat_map.

Library wanted to make sure that Library Evolution was okay with these updates, as they contain some design changes.
After briefly reviewing the changes, we felt that they were fine and the papers can proceed in Library.

Next Steps

  • Publish D0429R9 (flat_map) and D1222R4 (flat_set).
  • Take an electronic poll to confirm returning D0429R9 (flat_map) and D1222R4 (flat_set) to Library for C++23 classified as B3 - addition.

@brycelelbach brycelelbach added the LEWG Library Evolution label Jun 17, 2022
@wg21bot
Copy link
Collaborator

wg21bot commented Jun 24, 2022

P1222R4 A Standard flat_set (Zach Laine)

@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Jun 29, 2022
@brycelelbach brycelelbach added the lwg-pending LWG Chair needs to disposition label Jul 8, 2022
@JeffGarland JeffGarland removed lwg-pending LWG Chair needs to disposition B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 labels Jul 8, 2022
@brycelelbach
Copy link

2022-07 Library Evolution Electronic Poll Outcomes

Poll 1.2: Return [P1222R4] flat_set to Library Working Group for C++23, classified as an addition ([P0592R4] bucket 3 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
15 13 1 0 0

Outcome: Strong consensus in favor.

@brycelelbach brycelelbach removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jul 22, 2022
@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Jul 25, 2022
@tkoeppe
Copy link

tkoeppe commented Aug 14, 2022

This has been applied.

@tkoeppe tkoeppe closed this as completed Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
None yet
Development

No branches or pull requests

10 participants