Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1636 Formatters for library types #425

Closed
wg21bot opened this issue Jun 23, 2019 · 11 comments
Closed

P1636 Formatters for library types #425

wg21bot opened this issue Jun 23, 2019 · 11 comments
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting size - medium paper size estimate

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Jun 23, 2019

P1636R0 Formatters for library types (Lars Gullik Bjønnes)

@wg21bot wg21bot added this to the 2019-07 milestone Jun 23, 2019
@wg21bot wg21bot added the LEWG Library Evolution label Jun 23, 2019
@jensmaurer jensmaurer added this to Wednesday in LEWG in Cologne 2019 Jul 13, 2019
@tituswinters
Copy link

unique_ptr and shared_ptr should format via cast-to-void*. (If no, then formatting unique_ptr and shared_ptr is unsupported.)
SF F N A SA
0 3 5 3 1

Throw invalid_format when encountering a leading 0 in the width specifier for complex.
SF F N A SA
0 1 2 7 0

Update paper with “basic_streambuf is not supported by format.”
Unanimous consent

Make the above clarifications, forward to LWG for C++20.
SF F N A SA
3 7 0 0 0

In theory, adding formatters after we ship C++20 is not a breaking change (so long as users aren't defining their own formatters for our types). This is a nice-to-have for C++20.

@tituswinters tituswinters added LWG Library and removed LEWG Library Evolution labels Jul 17, 2019
@mclow mclow added the C++20 Targeted at C++20 label Jul 18, 2019
@wg21bot
Copy link
Collaborator Author

wg21bot commented Aug 23, 2019

P1636R1 Formatters for library types (Lars Gullik Bjønnes)

@wg21bot wg21bot modified the milestones: 2019-07, 2019-11 Aug 23, 2019
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 15, 2019

P1636R2 Formatters for library types (Lars Gullik Bjønnes)

@mclow mclow removed the C++20 Targeted at C++20 label Nov 3, 2019
@mclow
Copy link

mclow commented Nov 3, 2019

This was not adopted for C++20. Removing the "C++20" label.

@JeffGarland JeffGarland added C++23 Targeted at C++23 lwg-prereview Needs LWG initial review before full group labels Feb 17, 2020
@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-06 Feb 18, 2020
@jensmaurer jensmaurer added IS Ship vehicle: IS and removed C++23 Targeted at C++23 labels Feb 18, 2020
@ben-craig ben-craig added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - medium paper size estimate labels Oct 17, 2020
@jensmaurer jensmaurer modified the milestones: 2020-telecon, 2021-telecon Dec 28, 2020
@JeffGarland
Copy link
Member

LWG will review this on 2021-08-27

@JeffGarland
Copy link
Member

LWG review 2021-08-27 and has requested updates:

https://wiki.edg.com/bin/view/Wg21telecons2021/P1636-20210827

@JeffGarland JeffGarland added lwg-fullreview Paper is ready for lwg full group review needs-revision Paper needs changes before it can proceed C++23 Targeted at C++23 and removed lwg-prereview Needs LWG initial review before full group labels Sep 18, 2021
@tahonermann
Copy link
Collaborator

SG16 reviewed P1636R2 at its September 22nd, 2021 telecon. The following polls were taken.

Poll 1: Recommend removing the filesystem::path formatter from P1636 "Formatters for library types", and specifically disabling filesystem::path formatting in P2286 "Formatting ranges", pending a proposal with specific design for how to format paths properly.

  • Attendance: 12
  • SF F N A SA
    5 5 1 0 0
  • Strong consensus in favor.

Victor Zverovich and Peter Brett volunteered to author a proposal to add formatting support for std::filesystem::path with appropriate handling of encoding conversions, non-representable characters, quoting, etc...

@jensmaurer jensmaurer removed this from the 2021-telecon milestone Nov 12, 2021
@JeffGarland JeffGarland added lwg-blocked LWG has dispositioned this paper as inactive -- unable to move forward and removed lwg-fullreview Paper is ready for lwg full group review labels Jun 23, 2022
@JeffGarland JeffGarland added C++26 Targeted at C++26 and removed C++23 Targeted at C++23 labels Sep 27, 2022
@JeffGarland
Copy link
Member

This paper has missed c++23 -- unclear if it's still alive.

@brycelelbach
Copy link

There's an NB comment requesting this for C++23 (cplusplus/nbballot#410). Library Evolution is yanking this back into our domain. Hopefully we'll be able to cut this down into something we can ship.

@brycelelbach brycelelbach added LEWG Library Evolution C++23 Targeted at C++23 ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting and removed LWG Library lwg-blocked LWG has dispositioned this paper as inactive -- unable to move forward needs-revision Paper needs changes before it can proceed C++26 Targeted at C++26 labels Nov 4, 2022
@brycelelbach
Copy link

I am told a new paper or a revision of this paper will be produced.

@brycelelbach brycelelbach added the needs-revision Paper needs changes before it can proceed label Nov 4, 2022
@brycelelbach
Copy link

Closing, as we now have P2693 #1358, which addresses some of the things in this paper. If someone wants more, please write a new paper or revise this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting size - medium paper size estimate
Projects
No open projects
Development

No branches or pull requests

8 participants