Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1926 Making std::priority_queue constexpr #668

Closed
wg21bot opened this issue Oct 15, 2019 · 5 comments
Closed

P1926 Making std::priority_queue constexpr #668

wg21bot opened this issue Oct 15, 2019 · 5 comments
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e constexpr IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list size - small paper size estimate

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Oct 15, 2019

P1926R0 Making std::priority_queue constexpr (Alexander Zaitsev)

@wg21bot wg21bot added the LEWGI Library Evolution Incubator label Oct 15, 2019
@wg21bot wg21bot added this to the 2019-11 milestone Oct 15, 2019
@sempuki
Copy link
Collaborator

sempuki commented Nov 6, 2019

Belfast 2019-11 LEWGI Minutes

P1922r0
P1923r0
P1924r0
P1925r0
P1926r0
P1929r0
constexpr std::list, et al.: Direction Review

Chair: Ryan McDougall

Champion: Anton Polukhin

Minute Taker: CJ Johnson

Start Review: 5 11:27

Start Polling: 11:40

POLL: We should promise more committee time to pursuing P1922-6, P1929
(constexpr std::list, et al.), without knowing if all other std library types can be constexpr'd.

Strongly For Weakly For Neutral Weakly Against Strongly Against
1 7 2 1 2

CONSENSUS

Attendance: 15

POLL: We should promise more committee time to pursuing P1922-6, P1929
(constexpr std::list, et al.) and forward it to LEWG, knowing that our time is scarce and this will leave less time for other work.

Strongly For Weakly For Neutral Weakly Against Strongly Against
1 8 1 2 1

Attendance: 15

CONSENSUS

End: 11:47

@brycelelbach brycelelbach added LEWG Library Evolution and removed LEWGI Library Evolution Incubator labels Nov 7, 2019
@brycelelbach
Copy link

Belfast 2019-11 LEWGI Minutes

Container Constexprification: Direction Review

Chair: Ryan McDougall

Champion: Antony Polukhin

Minute Taker: CJ Johnson

Start: 11-06 11:27

End: 11:48

CONSENSUS: LEWGI sends P1922-6 and P1929 (Container Constexperification) to LEWG.

@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-02 Dec 11, 2019
@brycelelbach brycelelbach added this to Weekly Mailing List Discussions in Library Evolution Telecons Apr 21, 2020
@brycelelbach brycelelbach moved this from Weekly Mailing List Discussions to 2020-05-12 Telecon in Library Evolution Telecons May 10, 2020
@brycelelbach brycelelbach moved this from 2020-05-12 Telecon to Weekly Mailing List Discussions in Library Evolution Telecons May 12, 2020
@cor3ntin
Copy link

Summary of the reflector review (week of June 15 2020)

There is no particular concerns for the proposals at hand, however stack and queue require a constexpr container with pop_front, for which there are implementations concerns
During the review, someone provided an implementation of a simplified constexpr deque
It is unclear whether std::deque itself can be made constexpr without changes to the core language.
On their own, the proposals cannot be tested. There seems to be some preference that the default container adapted by stack and queue (ie deque) is made constexpr
before the adapter themselves are, both to prove the design and to make them usable without an user-provided container type)

The author is encouraged to provide one, preferably 2, tested implementations, of the constexpr containers, and to provide more analysis of the implementability in the papers (for list, forward list and deque),
and in particular, explore whether changes to the core languages would be needed. We noted that pointer_traits::pointer_to should be constexpr. LWG3446 also affected his implementation attempt.
P1974 may also impact how these proposals are implemented.

There were no concerns about priority_queue (but again, tests should be provided)

Guidance: P1923, P1922 and P1929 (#664 #671 and #665) need to be update with implementation experience and description of potential core language impact. P1924, P1925 (#666 #667) should be reviewed again after P1923 (#665) has been updated. no concern for P1926 (#668)

@cor3ntin cor3ntin removed this from Weekly Mailing List Discussions in Library Evolution Telecons Jun 24, 2020
@brycelelbach brycelelbach added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Aug 25, 2020
@brycelelbach brycelelbach added the needs-revision Paper needs changes before it can proceed label Oct 20, 2020
@brycelelbach
Copy link

Blocked on updates to other papers, marking needs-revision. Authors: you will need to proactively tell us when this is ready for review again, either by publishing a new revision or emailing us.

@jensmaurer jensmaurer modified the milestones: 2020-02, 2021-telecon Dec 28, 2020
@jensmaurer jensmaurer removed this from the 2021-telecon milestone Nov 12, 2021
@brycelelbach brycelelbach added constexpr size - small paper size estimate labels May 24, 2023
@brycelelbach
Copy link

Closing due to more than 1 year of inactivity. Please re-open if further work is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e constexpr IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list size - small paper size estimate
Projects
No open projects
Development

No branches or pull requests

5 participants