Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P1989 Range constructor for std::string_view 2: Constrain Harder #714

Closed
wg21bot opened this issue Dec 11, 2019 · 6 comments · Fixed by cplusplus/draft#4676
Closed

P1989 Range constructor for std::string_view 2: Constrain Harder #714

wg21bot opened this issue Dec 11, 2019 · 6 comments · Fixed by cplusplus/draft#4676
Labels
C++23 Targeted at C++23 LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges
Milestone
2021-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Dec 11, 2019

P1989R0 Range constructor for std::string_view 2: Constrain Harder (Corentin Jabot)
@wg21bot wg21bot added the LWG Library label Dec 11, 2019
@wg21bot wg21bot added this to the 2020-02 milestone Dec 11, 2019
@JeffGarland JeffGarland added the lwg-prereview Needs LWG initial review before full group label Mar 24, 2020
@JeffGarland JeffGarland added the ranges std::ranges label May 22, 2020
@ben-craig ben-craig added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - small paper size estimate labels Oct 17, 2020
@cor3ntin cor3ntin mentioned this issue Nov 17, 2020
Closed
@jensmaurer jensmaurer modified the milestones: 2020-02, 2021-telecon Dec 28, 2020
@JeffGarland JeffGarland added lwg-fullreview Paper is ready for lwg full group review and removed lwg-prereview Needs LWG initial review before full group labels Jan 8, 2021
@JeffGarland
Copy link
Member

JeffGarland commented Jan 8, 2021 •
edited

Reviewed by LWG 1/8/2021 meeting (D1989R1.pdf) without author present -- changes on feedback will be provided. Some small changes are needed and an action item to LWG assistant chair to check with implementors on implementation concerns w.r.t. breaking existing code. Notes:

https://wiki.edg.com/bin/view/Wg21telecons2021/D1989R1-20210108

@wg21bot
Copy link
Collaborator Author

wg21bot commented Jan 22, 2021

P1989R1 Range constructor for std::string_view 2: Constrain Harder (Corentin Jabot)

@JeffGarland
Copy link
Member

One implementer has successfully made the change and passed the test coverage suite -- 95% confidence level. Paper should be rescheduled for final review.

@JeffGarland
Copy link
Member

JeffGarland commented Mar 13, 2021 •
edited by jensmaurer

LWG addressed the R1 and the draft of R2 version.

https://wiki.edg.com/bin/view/Wg21telecons2021/P1989-20210312

Poll: move p1989r2 into the C++23 working paper (with the rationale comment added)

F A N
12 0 0

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e lwg-fullreview Paper is ready for lwg full group review size - small paper size estimate labels Mar 13, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Apr 25, 2021

P1989R2 Range constructor for std::string_view 2: Constrain Harder (Corentin Jabot)

@jwakely jwakely added the C++23 Targeted at C++23 label May 20, 2021
@cor3ntin cor3ntin added plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. and removed tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. labels Jun 7, 2021
@jensmaurer jensmaurer mentioned this issue Jun 9, 2021
Merged
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 26, 2021

Adopted 2021-06.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges
Projects
None yet
Milestone
2021-telecon
Development

Successfully merging a pull request may close this issue.

P1989R2 Range constructor for std::string_view 2: Constrain Harder cplusplus/draft
6 participants
@ben-craig @jwakely @cor3ntin @JeffGarland @jensmaurer @wg21bot