Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2014 Proposed resolution for US061/US063 - aligned allocation of coroutine frames #750

Open
wg21bot opened this issue Jan 18, 2020 · 8 comments
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 CWG Core IS Ship vehicle: IS needs-revision Paper needs changes before it can proceed

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Jan 18, 2020

P2014R0 Proposed resolution for US061/US062 - aligned allocation of coroutine frames (Lewis Baker, Gor Nishanov)

@wg21bot wg21bot added the EWG Evolution label Jan 18, 2020
@wg21bot wg21bot added this to the 2020-02 milestone Jan 18, 2020
@jfbastien jfbastien added this to C++20 in EWG Prague Jan 18, 2020
@jfbastien jfbastien moved this from C++20 to Monday in EWG Prague Jan 23, 2020
@jfbastien jfbastien added the C++20 Targeted at C++20 label Jan 23, 2020
@jensmaurer jensmaurer changed the title P2014 Proposed resolution for US061/US062 - aligned allocation of coroutine frames P2014 Proposed resolution for US061/US063 - aligned allocation of coroutine frames Feb 10, 2020
@jensmaurer
Copy link
Member

(This paper is probably not related to US062.)

@jfbastien
Copy link
Collaborator

See in EWG Prague Monday afternoon.

Option 1: Call align_val_t allocation function if available for over aligned coroutine frames

SF F N A SA
3 7 4 3 2

Option 2: Always prefer calling align_val_t allocations regardless of alignment requirement

SF F N A SA
4 8 2 5 1

Option 3: Only call align_val_t allocation functions

SF F N A SA
5 12 0 4 1

Consensus on option 3 only.

Lewis to come back to EWG with an updated paper with option 3.

@jfbastien
Copy link
Collaborator

EWG Prague on Tuesday morning.

Same polls as last time, with the updated information.

Option 3: Only call align_val_t allocation functions

SF F N A SA
0 0 2 10 6

Option 2: Always prefer calling align_val_t allocations regardless of alignment requirement

SF F N A SA
0 0 2 13 4

Option 1: Call align_val_t allocation function if available for over aligned coroutine frames

SF F N A SA
0 8 5 2 3

No consensus for change.

@jensmaurer jensmaurer removed the C++20 Targeted at C++20 label Apr 23, 2021
@jfbastien
Copy link
Collaborator

One of the authors tells us that the lack of consensus was based on timing for C++20, not on technical merits. Reopening to discuss inclusion for C++26.

@erichkeane
Copy link
Collaborator

This was discussed at the August 18, 2022 EWG Telecon.

No polls were taken, and the authors were encouraged to discuss motivation and implementation options with other implementers, NB comment submitters, and the reflector.

@brycelelbach brycelelbach added the LEWG Library Evolution label Aug 18, 2022
@brycelelbach brycelelbach added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - small paper size estimate ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting IS Ship vehicle: IS and removed size - small paper size estimate labels Sep 22, 2022
@brycelelbach
Copy link

Actually I don't think we need to see this at this phase.

@brycelelbach brycelelbach removed LEWG Library Evolution ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Sep 22, 2022
@erichkeane
Copy link
Collaborator

Forward Option 1 from P2014R0 (Prefer align_val_t overload only if overaligned) to CWG for inclusion in C++26.

SF F N A SA
4 12 1 0 0

Result: Consensus

@jfbastien jfbastien added CWG Core and removed EWG Evolution labels Nov 9, 2022
@jensmaurer jensmaurer added this to Ready for review in CWG Nov 9, 2022
@jensmaurer jensmaurer modified the milestones: 2020-02, 2023-02 Jan 25, 2023
@jensmaurer jensmaurer moved this from Ready for review to Awaiting updated wording in CWG Feb 9, 2023
@jensmaurer
Copy link
Member

CWG 2023-02-08: Reviewed D2014R2; needs updates.

@jensmaurer jensmaurer added the needs-revision Paper needs changes before it can proceed label Feb 9, 2023
@jensmaurer jensmaurer removed this from the 2023-02 milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 CWG Core IS Ship vehicle: IS needs-revision Paper needs changes before it can proceed
Projects
CWG
Awaiting updated wording
Development

No branches or pull requests

5 participants