Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2166 A Proposal to Prohibit std::basic_string and std::basic_string_view construction from nullptr #887

Closed
wg21bot opened this issue Jun 17, 2020 · 9 comments · Fixed by cplusplus/draft#4678
Closed

P2166 A Proposal to Prohibit std::basic_string and std::basic_string_view construction from nullptr #887

wg21bot opened this issue Jun 17, 2020 · 9 comments · Fixed by cplusplus/draft#4678
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate
Projects
Library Evolution Telecons Library Evolution Mailing List Reviews
Milestone
2021-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Jun 17, 2020

P2166R0 A Proposal to Prohibit std::basic_string and std::basic_string_view construction from nullptr (Yuriy Chernyshov)
@wg21bot wg21bot added LEWG Library Evolution LEWGI Library Evolution Incubator LWG Library labels Jun 17, 2020
@wg21bot wg21bot added this to the 2020-telecon milestone Jun 17, 2020
@brycelelbach brycelelbach added this to Weekly Mailing List Discussions in Library Evolution Telecons Jun 29, 2020
@brycelelbach brycelelbach added LEWG Library Evolution B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list and removed LEWG Library Evolution LWG Library LEWGI Library Evolution Incubator labels Aug 25, 2020
@cor3ntin
Copy link

cor3ntin commented Sep 21, 2020 •
edited

Mailing list review 2020-09-07 - 2020-09-21

There seems to be a lot of agreement that this is useful but I still see some objections (most of which based on R0, not R1) no real actionable items for the author.A question was whether contracts would alleviate the need for this proposal, another one was whether it was wise to do something for the static case when a pointer null at runtime would still lead to UB, to which people replied that it does improve safety if not absolutely. A R1 was posted after the start of the review, I suppose it will be in the next mailing.

Ready to be looked at by LEWG, when there is some down time in LEWG.

@cor3ntin cor3ntin removed the ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list label Sep 21, 2020
@cor3ntin
Copy link

cor3ntin commented Sep 21, 2020 •
edited by brycelelbach

@brycelelbach why is that B2?

@brycelelbach
Copy link

brycelelbach commented Sep 22, 2020 via email

@wg21bot
Copy link
Collaborator Author

wg21bot commented Sep 23, 2020

P2166R1 A Proposal to Prohibit std::basic_string and std::basic_string_view construction from nullptr (Yuriy Chernyshov)

@brycelelbach brycelelbach added C++23 Targeted at C++23 ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll labels Oct 15, 2020
@ben-craig ben-craig added the size - small paper size estimate label Nov 22, 2020
@brycelelbach
Copy link

brycelelbach commented Dec 9, 2020 •
edited

P2166R1: A Proposal to Prohibit basic_string and basic_string_view construction from nullptr

2020-10-19 Library Evolution Telecon Minutes

Chair: Nevin Liber

Champion: Nevin Liber

Minute Taker: Ben Craig

POLL: Forward P2166R1 for LEWG electronic ballot.

SF WF N WA SA
2 7 3 4 0

Attendees: 31

# of Authors: 0

Outcome: Consensus in favor.

Outcome

We will poll whether to send P2166R1 (A Proposal to Prohibit basic_string and basic_string_view construction from nullptr) to LWG in the 2020 Fall Library Evolution polls.

@brycelelbach
Copy link

brycelelbach commented Dec 9, 2020 •
edited

2020 Fall Library Evolution Polls

P2262: 2020 Fall Library Evolution Poll Outcomes

POLL 7: Send P2166R1 (Prohibit basic_string and basic_string_view Construction from nullptr) to LWG for C++23, classified as an improvement of an existing feature (P0592R4 bucket 2 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
15 18 2 2 1

Outcome: Consensus in favor.

Outcome

P2166R1 (Prohibit basic_string and basic_string_view Construction from nullptr) is sent to LWG for C++23, classified as an improvement of an existing feature (P0592R4 bucket 2 item).

@brycelelbach brycelelbach added LWG Library and removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll labels Dec 9, 2020
@jensmaurer jensmaurer modified the milestones: 2020-telecon, 2021-telecon Dec 28, 2020
@JeffGarland JeffGarland added the lwg-prereview Needs LWG initial review before full group label Jan 27, 2021
@JeffGarland JeffGarland removed the lwg-prereview Needs LWG initial review before full group label Feb 12, 2021
@JeffGarland JeffGarland added the lwg-fullreview Paper is ready for lwg full group review label Feb 12, 2021
@JeffGarland
Copy link
Member

LWG review tentatively scheduled for 2021-02-19

@JeffGarland
Copy link
Member

Reviewed 2021-02-19 in LWG Telecon

https://wiki.edg.com/bin/view/Wg21telecons2021/P2166-20210219

Poll: Add P2166R1 to C++ working draft for c++23
F N A
13 0 0

Will be added to Summer Plenary.

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e lwg-fullreview Paper is ready for lwg full group review labels Feb 19, 2021
@cor3ntin cor3ntin added plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. C++20 Targeted at C++20 and removed tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. labels Jun 7, 2021
@jensmaurer jensmaurer removed the C++20 Targeted at C++20 label Jun 9, 2021
@jensmaurer jensmaurer mentioned this issue Jun 9, 2021
Merged
@jensmaurer jensmaurer added the C++20 Targeted at C++20 label Jun 9, 2021
@statementreply statementreply mentioned this issue Jun 11, 2021
Merged
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 26, 2021

Adopted 2021-06.

@jensmaurer jensmaurer removed the C++20 Targeted at C++20 label Oct 26, 2021
@mbs-c mbs-c mentioned this issue Feb 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate
Projects
No open projects
Library Evolution Mailing List Reviews
Unscheduled
Library Evolution Telecons
Unscheduled
Milestone
2021-telecon
Development

Successfully merging a pull request may close this issue.

P2166R1 A Proposal to Prohibit std::basic_string and std::basic_strin… cplusplus/draft
6 participants
@brycelelbach @ben-craig @cor3ntin @JeffGarland @jensmaurer @wg21bot