Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2187 std::swap_if, std::predictable #899

Closed
wg21bot opened this issue Aug 1, 2020 · 4 comments
Closed

P2187 std::swap_if, std::predictable #899

wg21bot opened this issue Aug 1, 2020 · 4 comments
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed size - medium paper size estimate

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Aug 1, 2020

P2187R3 std::swap_if, std::predictable (Nathan Myers)

@wg21bot wg21bot added LEWG Library Evolution LEWGI Library Evolution Incubator labels Aug 1, 2020
@wg21bot wg21bot added this to the 2020-telecon milestone Aug 1, 2020
@wg21bot
Copy link
Collaborator Author

wg21bot commented Aug 23, 2020

P2187R4 std::swap_if, std::predictable (Nathan Myers)

@brycelelbach brycelelbach added LEWG Library Evolution B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 IS Ship vehicle: IS ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list and removed LEWG Library Evolution LEWGI Library Evolution Incubator labels Aug 25, 2020
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 27, 2020

P2187R5 std::swap_if, std::predictable (Nathan Myers)

@brycelelbach
Copy link

2020-10-19 Library Evolution Mailing List Review

I believe we want at least one piece of this: swap_if.

Specifying a specific overload for swap_if on trivially relocatable or cheaply swappable types does not seem like an essential feature of swap_if to specify. It can be quality of implementation; it can be extended later when we have P1144.

I've not heard as much discussion or support for predictable.

Based on this discussion, this paper should be revised as follows:

  • Remove is_trivially_swappable, etc; leave a section in mentioning it as a possible future extension once P1144 has advanced.
  • Don't try to specify a particular implementation strategy for swap_if: until we have something like P1144, it can just be QoI.
  • Remove predictable. Perhaps separate it into a separate paper, if you feel strongly about it, but there is greater consensus and interest in swap_if than there is for predictable.

@brycelelbach brycelelbach added the needs-revision Paper needs changes before it can proceed label Nov 13, 2020
@jensmaurer jensmaurer removed this from the 2020-telecon milestone Dec 27, 2020
@brycelelbach brycelelbach added size - medium paper size estimate and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels May 24, 2023
@brycelelbach
Copy link

Closing due to more than 1 year of inactivity. Please re-open if further work is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed size - medium paper size estimate
Projects
No open projects
Development

No branches or pull requests

3 participants