Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2223 Trimming whitespaces before line splicing #925

Closed
wg21bot opened this issue Sep 23, 2020 · 6 comments · Fixed by cplusplus/draft#4666
Closed

P2223 Trimming whitespaces before line splicing #925

wg21bot opened this issue Sep 23, 2020 · 6 comments · Fixed by cplusplus/draft#4666
Labels
C++23 Targeted at C++23 CWG Core plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. SG22 C / C++ liaison
Projects
CWG
Milestone
2021-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Sep 23, 2020

P2223R0 Trimming whitespaces before line splicing (Corentin Jabot)
@wg21bot wg21bot added CWG Core EWG Evolution labels Sep 23, 2020
@wg21bot wg21bot added this to the 2020-telecon milestone Sep 23, 2020
@jfbastien jfbastien removed the CWG Core label Sep 23, 2020
@jfbastien
Copy link
Collaborator

Seen in today's EWG telecon.

P2223R0 make trailing whitespace after an end-of-line backslash non-significant (note: this leaves handling of raw string literals untouched).

SF F N A SA
3 9 1 0 0

P2223R0 fix CWG1698 as proposed in the paper.

SF F N A SA
0 4 3 1 2

Corentin will update the paper, and then we'll vote on sending it to CWG.

@jfbastien jfbastien added EWG-vote-on-me EWG can vote on this needs-revision Paper needs changes before it can proceed labels Oct 14, 2020
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 27, 2020

P2223R1 Trimming whitespaces before line splicing (Corentin Jabot)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Oct 27, 2020
@jensmaurer jensmaurer modified the milestones: 2020-telecon, 2021-telecon Dec 28, 2020
@AaronBallman AaronBallman added the SG22 C / C++ liaison label Jan 22, 2021
@jensmaurer jensmaurer added this to Ready for review in CWG Feb 2, 2021
@jfbastien
Copy link
Collaborator

jfbastien commented Mar 9, 2021 •
edited

EWG February 2021 polls:

Poll: Forward P2223R1 "Trimming whitespaces before line splicing" to Core, thereby also fixing [CWG1698].

SF F N A SA
11 15 4 0 0

Poll outcome: ✅ consensus.

Salient comments:

  • Strongly in favor as this aligns the standard with common practice, avoids contorting standard wording by implementations in order to claim conformance while producing the behavior programmers want, and avoids needless surprised and implementation divergence.
  • We should not have implementation divergence on this, and this direction to resolve it is good.
  • I’m not particularly excited about this paper because it only partially solves the problem of implementation divergence in this space and does not outline a play to solve all the existing issues in a consistent way. This will not likely impact my users.
  • Invisible differences in the behavior of code are bad.
  • Reducing divergence in compilers is good.
  • I find this somewhat unimportant.

@jfbastien jfbastien added CWG Core and removed EWG Evolution EWG-vote-on-me EWG can vote on this labels Mar 9, 2021
@jensmaurer jensmaurer moved this from Ready for review to Approved for plenary vote in CWG Apr 12, 2021
@jensmaurer
Copy link
Member

CWG 2021-04-12: Approved D2223R2 for plenary vote.

@jensmaurer jensmaurer added the straw-poll Straw poll label Apr 12, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Apr 25, 2021

P2223R2 Trimming whitespaces before line splicing (Corentin Jabot)

@cor3ntin cor3ntin added plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. C++23 Targeted at C++23 labels Jun 7, 2021
@jensmaurer jensmaurer mentioned this issue Jun 8, 2021
Merged
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 26, 2021

Adopted 2021-06.

@jensmaurer jensmaurer removed the straw-poll Straw poll label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 CWG Core plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. SG22 C / C++ liaison
Projects
CWG
Approved for plenary vote
Milestone
2021-telecon
Development

Successfully merging a pull request may close this issue.

P2223R2 Trimming whitespaces before line splicing cplusplus/draft
5 participants
@jfbastien @cor3ntin @AaronBallman @jensmaurer @wg21bot