Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2251 Require span & basic_string_view to be Trivially Copyable #946

Closed
wg21bot opened this issue Nov 23, 2020 · 10 comments · Fixed by cplusplus/draft#5000
Closed

P2251 Require span & basic_string_view to be Trivially Copyable #946

wg21bot opened this issue Nov 23, 2020 · 10 comments · Fixed by cplusplus/draft#5000
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote.
Milestone
2021-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Nov 23, 2020

P2251R0 Require span & basic_string_view to be Trivially Copyable (Nevin Liber)
@wg21bot wg21bot added the LEWGI Library Evolution Incubator label Nov 23, 2020
@wg21bot wg21bot added this to the 2020-telecon milestone Nov 23, 2020
@brycelelbach brycelelbach changed the title P2251 Require span & basic_string_view to be Trivially Copyable P2251 Require span & basic_string_view to be Trivially Copyable Nov 30, 2020
@brycelelbach brycelelbach added LEWG Library Evolution B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list and removed LEWGI Library Evolution Incubator labels Nov 30, 2020
@jensmaurer jensmaurer modified the milestones: 2020-telecon, 2021-telecon Dec 28, 2020
@cor3ntin cor3ntin added the size - tiny paper size estimate, smaller than small label Jan 29, 2021
@cor3ntin
Copy link

@brycelelbach I think this should go straight to LEWG, no point in mailing list review

@cor3ntin
Copy link

@brycelelbach or LWG directly - It seems to be a lwg issue to me

@nliber
Copy link
Collaborator

nliber commented Feb 22, 2021

When I brought it up in LWG, they wanted it run by LEWG, hence this small paper.

@cor3ntin
Copy link

@nliber Oh. I will send it directly to bryce, nothing we can do on the mailing

@cor3ntin cor3ntin added ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Feb 22, 2021
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Feb 23, 2021
@ben-craig
Copy link
Collaborator

P2251R0: Require span & basic_string_view to be Trivially Copyable

P2251R0: Require span & basic_string_view to be Trivially Copyable

2021-03-16 Library Evolution Telecon Minutes

Chair: Ben Craig

Champion: Nevin Liber

Minute Taker: Inbal Levi

SUMMARY:
We discussed whether this would make span usable as a NTTP. Since members aren't public, it shouldn't.

There was also some discussion on whether we technically need to do anything, because =default may be enough.

OUTCOME:

POLL: Send P2251R0 (Require span & basic_string_view to be Trivially Copyable) to LEWG Electronic Balloting for C++23, with priority B2: Improvement.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
16 5 0 0 0

Attendance: 30

# of Authors: 1

Author Position: SF

Outcome: Unanimous consent

ACTION: Mention motivation in updated revision.

@ben-craig ben-craig added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Mar 19, 2021
@brycelelbach brycelelbach added the needs-revision Paper needs changes before it can proceed label Mar 22, 2021
@brycelelbach brycelelbach added scheduled-for-library-evolution-electronic-poll and removed needs-revision Paper needs changes before it can proceed labels Apr 23, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Apr 25, 2021

P2251R1 Require span & basic_string_view to be Trivially Copyable (Nevin Liber)

@brycelelbach brycelelbach added scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed scheduled-for-library-evolution-electronic-poll labels Apr 27, 2021
@brycelelbach
Copy link

2021 Spring Library Evolution Polls

P2384: 2021 Spring Library Evolution Poll Outcomes

POLL 6: Send P2251R1 (Require span & basic_string_view To Be Trivially Copyable) to Library Working Group for C++23, classified as an improvement of an existing feature (P0592R4 bucket 2 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
21 10 0 0 0

Outcome: Unanimous consensus in favor.

@brycelelbach brycelelbach added the LWG Library label May 28, 2021
@brycelelbach brycelelbach removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels May 28, 2021
@JeffGarland JeffGarland added the lwg-fullreview Paper is ready for lwg full group review label May 28, 2021
@JeffGarland
Copy link
Member

LWG reviewed and approved for c++23 on 2021-06-04

https://wiki.edg.com/bin/view/Wg21telecons2021/P2251-20210604

add p2251r1 to the C++23 working paper

F A N
11 0 0

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e lwg-fullreview Paper is ready for lwg full group review size - tiny paper size estimate, smaller than small labels Jun 15, 2021
@jwakely
Copy link
Member

jwakely commented Jun 15, 2021

As the paper says, this is already implemented and shipping. There is no need to ask about implementation/deployment experience before the plenary.

@JeffGarland JeffGarland added the C++23 Targeted at C++23 label Sep 18, 2021
@cor3ntin cor3ntin added plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. and removed tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. labels Oct 4, 2021
@jensmaurer jensmaurer mentioned this issue Oct 4, 2021
Merged
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 26, 2021

Adopted 2021-10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote.
Projects
None yet
Milestone
2021-telecon
Development

Successfully merging a pull request may close this issue.

P2251R1 Require span & basic_string_view to be Trivially Copyable cplusplus/draft
8 participants
@brycelelbach @ben-craig @nliber @jwakely @cor3ntin @JeffGarland @jensmaurer @wg21bot