Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2283 constexpr for specialized memory algorithms #975

Open
wg21bot opened this issue Jan 22, 2021 · 10 comments
Open

P2283 constexpr for specialized memory algorithms #975

wg21bot opened this issue Jan 22, 2021 · 10 comments
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 constexpr IS Ship vehicle: IS LWG Library lwg-pending LWG Chair needs to disposition size - small paper size estimate
Milestone

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Jan 22, 2021

P2283R0 constexpr for specialized memory algorithms (Michael Schellenberger Costa)

@wg21bot wg21bot added the LEWG Library Evolution label Jan 22, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Jan 22, 2021
@brycelelbach brycelelbach added the ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list label Jan 25, 2021
@cor3ntin cor3ntin added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Feb 22, 2021
@cor3ntin
Copy link

cor3ntin commented Mar 29, 2021

Mailing list review 22-02-2021 - 29-03-2021

  • Address that this is in fact not a pure library change and might require compiler support and approval from CWG - EWG
  • to_address is only valid on contiguous iterator, while these algorithms support forward iterators
  • explain in the paper why we can't use construct_at
  • Try to gather feedback from more implementers

Guidance: Update the paper for a future presentation in a LEWG meeting

@cor3ntin cor3ntin added needs-revision Paper needs changes before it can proceed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Mar 29, 2021
@miscco
Copy link

miscco commented Mar 29, 2021

Will provide a new revision with the review comments addressed.

Thanks for looking into this!

@wg21bot
Copy link
Collaborator Author

wg21bot commented Apr 25, 2021

P2283R1 constexpr for specialized memory algorithms (Michael Schellenberger Costa)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Apr 25, 2021
@brycelelbach brycelelbach added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 constexpr scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels May 17, 2021
@brycelelbach brycelelbach removed the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label May 26, 2021
@brycelelbach
Copy link

Sending this back to mailing list review. I'm thinking this can be seen again by the mailing list, then proceed to electronic poll.

@brycelelbach brycelelbach added ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list IS Ship vehicle: IS size - small paper size estimate and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting C++23 Targeted at C++23 labels Aug 1, 2021
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Sep 24, 2021
@cor3ntin
Copy link

Motion failed

@cor3ntin cor3ntin added needs-revision Paper needs changes before it can proceed and removed scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Nov 28, 2021
@cor3ntin cor3ntin added C++23 Targeted at C++23 and removed C++23 Targeted at C++23 labels Dec 8, 2021
@cor3ntin cor3ntin added the C++26 Targeted at C++26 label Dec 9, 2021
@cor3ntin
Copy link

cor3ntin commented Dec 9, 2021

Motion failed.
The author informed me they are unlikely to be able to produce a new revision for c++23.

Comments from the mailing list

Going through construct_at prevents guaranteed copy elision for
uninitialized_copy/move* when the source is a range of prvalues; this
needs to be properly analyzed and addressed in the paper.
From a quick look, for the algorithms in namespace ranges, this
appears to be just a pessimization (they are constrained with
constructible_from, so the construction is required to be well-formed
even with intermediate materialization). For std::uninitialized_copy*,
this looks like a breaking change. std::uninitialized_move* appears to
be unaffected.

@wg21bot
Copy link
Collaborator Author

wg21bot commented Dec 18, 2021

P2283R2 constexpr for specialized memory algorithms (Michael Schellenberger Costa)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Dec 18, 2021
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@ben-craig
Copy link
Collaborator

P2283R2: constexpr for specialized memory algorithms

P2283R2: constexpr for specialized memory algorithms

2022-06-14 Library Evolution Telecon Minutes

Chair: Ben Craig

Minute Taker: Inbal Levi

Champion: Michael Schellenberger Costa

Summary

POLL: Send P2283R2 (constexpr for specialized memory algorithms) to LWG for C++26 classified as B3 (to be confirmed with a Library Evolution electronic poll).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
0 9 4 0 0

Attendance: 18

# of Authors: 1

Author Position: WF

Outcome: Consensus

Next Steps

Await the outcome of the next electronic poll, then respond to LWG feedback as needed.

@ben-craig ben-craig added B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Jun 17, 2022
@brycelelbach brycelelbach added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 labels Jun 29, 2022
@brycelelbach brycelelbach added LWG Library lwg-pending LWG Chair needs to disposition and removed LWG Library lwg-pending LWG Chair needs to disposition labels Jul 8, 2022
@brycelelbach
Copy link

2022-07 Library Evolution Electronic Poll Outcomes

Poll 2.4: Send [P2283R2] constexpr Specialized Memory Algorithms to Library Working Group for C++26, classified as an improvement of an existing feature ([P0592R4] bucket 2 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
10 7 0 0 0

Outcome: Unanimous consensus in favor.

@brycelelbach brycelelbach added LWG Library lwg-pending LWG Chair needs to disposition and removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jul 22, 2022
@jensmaurer jensmaurer modified the milestones: 2023-telecon, 2024-telecon Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++26 Targeted at C++26 constexpr IS Ship vehicle: IS LWG Library lwg-pending LWG Chair needs to disposition size - small paper size estimate
Projects
Status: No status
Status: No status
Development

No branches or pull requests

6 participants