Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2325 Views should not be required to be default constructible #1007

Closed
wg21bot opened this issue Feb 22, 2021 · 8 comments · Fixed by cplusplus/draft#4683
Closed

P2325 Views should not be required to be default constructible #1007

wg21bot opened this issue Feb 22, 2021 · 8 comments · Fixed by cplusplus/draft#4683
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges
Milestone
2021-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Feb 22, 2021

P2325R0 Views should not be required to be default constructible (Barry Revzin)
@wg21bot wg21bot added the LEWG Library Evolution label Feb 22, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Feb 22, 2021
@brycelelbach brycelelbach added the ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting label Feb 23, 2021
@brycelelbach brycelelbach added the B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e label Mar 22, 2021
@brycelelbach
Copy link

P2325R1 Views should not be required to be default constructible (Barry Revzin)

@brycelelbach brycelelbach added C++23 Targeted at C++23 IS Ship vehicle: IS ranges std::ranges scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Mar 22, 2021
@JeffGarland JeffGarland added the C++20 Targeted at C++20 label Apr 9, 2021
@JeffGarland
Copy link
Member

Added the c++20 label to indicated we'd like this to apply to c++20 implementations.

@brycelelbach
Copy link

brycelelbach commented Apr 23, 2021 •
edited by nliber

2021-03-03 Library Evolution Telecon

P2325R1: Views should not be required to be default constructible

2021-03-30 Library Evolution Telecon Minutes

Chair: Nevin Liber

Champion: Barry Revzin

Minute Taker: Ben Craig

POLL: Revise P2325 with wording (as outlined in P2325R1) and a feature test macro and a recommendation for vendors to apply this to C++20, with the intent that such a revision will likely be forwarded to electronic polling for LWG in bucket 2 (bug fix).

SF WF N WA SA
13 8 0 0 0

Attendance: 28

# of Authors: 1

Author Position: SF

Outcome: Unanimous consensus in favor

Summary

There is a strong desire to relax this requirement, as it adds a default state to types only to meet this requirement, resulting in a performance impact. It does require a concept change, which is a break.

Outcome

Unanimous consent to revise the paper with a feature test macro and wording, with the intent that LEWG will likely forward that revision to electronic polling for LWG bucket 2 with a recommendation that vendors apply it to C++20.

@brycelelbach brycelelbach added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution-electronic-poll and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Apr 23, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Apr 25, 2021

P2325R2 Views should not be required to be default constructible (Barry Revzin)

@brycelelbach brycelelbach added scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed scheduled-for-library-evolution-electronic-poll labels Apr 27, 2021
@JeffGarland
Copy link
Member

This was approved by LWG in 2021-05-14 telecon. Will wait for

https://wiki.edg.com/bin/view/Wg21telecons2021/P1328-20210514

poll: assuming LEWG doesn't vote that down apply P2325r3 to the C++23 working paper and treat a Defect Report?

F A N
11 0 0

@brycelelbach I assume you weren't planning on scheduling LEWG again?

@wg21bot
Copy link
Collaborator Author

wg21bot commented May 21, 2021

P2325R3 Views should not be required to be default constructible (Barry Revzin)

@brycelelbach
Copy link

brycelelbach commented May 28, 2021 •
edited

2021 Spring Library Evolution Polls

P2384: 2021 Spring Library Evolution Poll Outcomes

POLL 2: Send P2325R2 (Views Should Not Be Required To Be Default Constructible) to Library Working Group for C++23, classified as an improvement of an existing feature (P0592R4 bucket 2 item), with the recommendation that implementations retroactively apply it to C++20.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
21 7 0 0 0

Outcome: Unanimous consensus in favor.

@brycelelbach brycelelbach removed LEWG Library Evolution lwg-wait-for-lewg-electronic-poll ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels May 28, 2021
@JeffGarland JeffGarland added the tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. label May 28, 2021
@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Jun 7, 2021
@cor3ntin cor3ntin removed the tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. label Jun 7, 2021
@jensmaurer jensmaurer mentioned this issue Jun 10, 2021
Merged
@JohelEGP JohelEGP mentioned this issue Aug 18, 2021
Open
@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 26, 2021

Adopted 2021-06.

@jensmaurer jensmaurer removed the C++20 Targeted at C++20 label Oct 26, 2021
var-const added a commit to llvm/llvm-project that referenced this issue Jan 18, 2023
@var-const
[libc++][ranges] Mark completed Ranges papers and issues as done, bum…
d94b069 
…p version macro

All C++20 Ranges papers and LWG issues are done, with the exception of
https://wg21.link/P2210R2 ("Superior String Splitting"), and marked as
such.

All of these were already implemented prior to this patch except bumping
the feature test macro `__cpp_lib_ranges` as required by
https://wg21.link/P2325R3 ("Views should not be required to be default
constructible"). Note that, even though P2325R3 was voted into C++23, it
was voted with a recommendation for vendors to retroactively apply the
change to C++20 (see cplusplus/papers#1007).

Differential Revision: https://reviews.llvm.org/D139900
CarlosAlbertoEnciso pushed a commit to SNSystems/llvm-debuginfo-analyzer that referenced this issue Jan 18, 2023
@var-const @CarlosAlbertoEnciso
[libc++][ranges] Mark completed Ranges papers and issues as done, bum…
9f0cb98 
…p version macro

All C++20 Ranges papers and LWG issues are done, with the exception of
https://wg21.link/P2210R2 ("Superior String Splitting"), and marked as
such.

All of these were already implemented prior to this patch except bumping
the feature test macro `__cpp_lib_ranges` as required by
https://wg21.link/P2325R3 ("Views should not be required to be default
constructible"). Note that, even though P2325R3 was voted into C++23, it
was voted with a recommendation for vendors to retroactively apply the
change to C++20 (see cplusplus/papers#1007).

Differential Revision: https://reviews.llvm.org/D139900
@brevzin brevzin mentioned this issue Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges
Projects
None yet
Milestone
2021-telecon
Development

Successfully merging a pull request may close this issue.

P2325R3 Views should not be required to be default constructible cplusplus/draft
5 participants
@brycelelbach @cor3ntin @JeffGarland @jensmaurer @wg21bot