Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2372 Fixing locale handling in chrono formatters #1039

Closed
brycelelbach opened this issue May 15, 2021 · 11 comments · Fixed by cplusplus/draft#5005
Closed

P2372 Fixing locale handling in chrono formatters #1039

brycelelbach opened this issue May 15, 2021 · 11 comments · Fixed by cplusplus/draft#5005
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote.
Milestone

Comments

@brycelelbach
Copy link

P2372R0 Fixing locale handling in chrono formatters (Victor Zverovich, Corentin Jabot)

@brycelelbach brycelelbach added the LEWG Library Evolution label May 15, 2021
@vitaut
Copy link

vitaut commented May 15, 2021

New revision: https://isocpp.org/files/papers/P2372R1.html

@ben-craig
Copy link
Collaborator

D2372R0: Fixing locale handling in chrono formatters

D2372R0: Fixing locale handling in chrono formatters

2021-05-03 Library Evolution Telecon Minutes

Chair: Ben Craig

Champion: Victor Zverovich

Minute Taker: Inbal Levi

Start: 2021-05-03

POLL: Revise D2372 to keep the ostream operators for chrono formatting dependent on the stream locale

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
10 8 2 0 0

Attendance: 28

# of Authors: 2

Author Position: SF, N

Outcome: Strong Consensus in Favor

POLL: LEWG approves of the direction of this work and encourages further work as directed above with the intent that D2372 (Fixing locale handling in chrono formatters) will land in C++23 and be applied retroactively to C++20

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
14 8 0 0 0

Attendance: 28

# of Authors: 2

Author Position: SF, SF

Outcome: Unanimous approval

Action for SG16: Retake poll on the direction. Capture the direction in that poll.

Action for Charlie Barto and Victor: Talk with STL (the person) to ensure he is aware of the likely coming changes. Also talk with Nico Josuttis, since he is working on a book.

@ben-craig ben-craig added needs-revision Paper needs changes before it can proceed B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++20 Targeted at C++20 C++23 Targeted at C++23 IS Ship vehicle: IS size - medium paper size estimate size - small paper size estimate and removed size - medium paper size estimate labels May 15, 2021
@tahonermann
Copy link
Collaborator

As noted in the minutes for the LEWG 2021-05-03 telecon, LEWG requested that SG16 affirm LEWG's direction regarding P2372 as indicated by polls in prior comments. This request was made because prior SG16 polls of the proposed resolution of LWG3547 did not indicate consensus for that direction as indicated in the minutes from the SG16 telecon held 2021-04-28.

SG16 conducted the following poll during our 2021-05-12 telecon and did affirm LEWG's direction.

POLL: Forward D2372R1 to LEWG for inclusion in C++23 and with the intent that it be applied retroactively to C++20.

SF F N A SA
5 2 1 0 0

Attendance: 8

Outcome: Strong consensus in favor.

Note that D2372R1 contains the LEWG requested changes to preserve locale dependent formatting for ostream formatters.

My perception is that SG16's change in consensus is attributable to two factors:

  1. New information that arrived after the initial poll.
  2. SG16's original poll targeted C++23 while LEWG's poll targeted C++23 and C++20 as a DR; some concerns had previously been expressed regarding backward compatibility and migration.

@wg21bot
Copy link
Collaborator

wg21bot commented May 21, 2021

P2372R1 Fixing locale handling in chrono formatters (Victor Zverovich, Corentin Jabot)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label May 21, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone May 21, 2021
@brycelelbach brycelelbach added the ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting label May 24, 2021
@ben-craig
Copy link
Collaborator

ben-craig commented Jun 8, 2021

2021-06-08 Library Evolution Telecon

P2372R1: Fixing locale handling in chrono formatters

2021-06-08 Library Evolution Telecon Minutes

Chair: Ben Craig

Champion: Victor Zverovich

Minute Taker: Inbal Levi

POLL: Send P2372R1 (Fixing locale handling in chrono formatters) to LWG for C++23 IS with priority 2 (Fixes), with the intent that it be applied retroactively to implementation's C++20 modes (to be confirmed with a Library Evolution electronic poll).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
12 3 1 0 0

Attendance: 23

# of Authors: 2

Author Position: SF, SF

Outcome: Strong consensus in favor

Summary

Victor brought the requested revisions, along with a few drive by fixes. The window for applying retroactive changes is almost closed at this point.

Outcome

Put in the next electronic poll. Targeting LWG and the C++23 IS with priority 2 (fixes), and applied retroactively to implementation's C++20 modes.

@brycelelbach brycelelbach added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Jun 10, 2021
@ben-craig ben-craig added the lwg-pending LWG Chair needs to disposition label Jun 13, 2021
@brycelelbach
Copy link
Author

The paper is being placed on the Summer 2021 electronic ballot.

@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Aug 1, 2021
@wg21bot
Copy link
Collaborator

wg21bot commented Aug 23, 2021

P2372R2 Fixing locale handling in chrono formatters (Victor Zverovich, Corentin Jabot)

@brycelelbach
Copy link
Author

2021 Summer Library Evolution Polls

P2435: 2021 Summer Library Evolution Poll Outcomes

POLL 2: Send P2372R1 (Fixing Locale Handling In Chrono Formatters) to Library Working Group for C++23, classified as an improvement of an existing feature (P0592R4 bucket 2 item), with the recommendation that implementations retroactively apply it to C++20.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
21 10 0 0 0

Outcome: Unanimous consensus in favor.

@brycelelbach brycelelbach added LWG Library and removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Sep 6, 2021
@JeffGarland
Copy link
Member

JeffGarland commented Sep 17, 2021

LWG reviewed and approved for c++23 and as a defect for C++20 on 2021-09-17

https://wiki.edg.com/bin/view/Wg21telecons2021/P2372-20210917

poll: put p2372r3 into the C++23 working paper?

F A N
9 0 0

poll: have p2372r3 as a DR for C++20?

F A N
8 0 1

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed lwg-pending LWG Chair needs to disposition B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - small paper size estimate labels Sep 17, 2021
@wg21bot
Copy link
Collaborator

wg21bot commented Sep 20, 2021

P2372R3 Fixing locale handling in chrono formatters (Victor Zverovich, Corentin Jabot)

@cor3ntin cor3ntin added plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. and removed tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. labels Oct 4, 2021
@wg21bot
Copy link
Collaborator

wg21bot commented Oct 26, 2021

Adopted 2021-10.

@jensmaurer jensmaurer removed the C++20 Targeted at C++20 label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants