Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2374 views::cartesian_product #1044

Closed
wg21bot opened this issue May 21, 2021 · 11 comments · Fixed by cplusplus/draft#5647
Closed

P2374 views::cartesian_product #1044

wg21bot opened this issue May 21, 2021 · 11 comments · Fixed by cplusplus/draft#5647
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Milestone
2022-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented May 21, 2021

P2374R0 views::cartesian_product (Sy Brand)
@wg21bot wg21bot added the LEWG Library Evolution label May 21, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone May 21, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented May 21, 2021

P2374R1 views::cartesian_product (Sy Brand)

@brycelelbach brycelelbach added ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review size - medium paper size estimate C++23 Targeted at C++23 ranges std::ranges B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 labels May 26, 2021
@inbal2l inbal2l added the needs-revision Paper needs changes before it can proceed label Jun 1, 2021
@inbal2l
Copy link
Collaborator

inbal2l commented Jun 1, 2021 •
edited by brycelelbach

2021-01-06 Library Evolution Telecon Minutes

Chair: Inbal Levi

Champion: Sy Brand

Minute Taker: Ben Craig

Start: 2021-01-06 10:02 Pacific

POLL: We would like to have special case relaxations on the requirements for the first underlying range in cartesian_product_view

SF F N A SA
1 7 8 6 3

Attendance: 28

Num of Authors: 1

Authors' Position: A

Outcome: No Consensus to change

POLL: We like the name "cartesian_product_view".

Attendance: 28

Num of Authors: 1

Outcome: No objection to unanimous consent

Summary

The proposal generally had broad support, apart from few issues and clarifications, which will be fixed on the next revision:
Wording should go in header, CTOR should be explicit (as in zip), add a design section for "enable_borrowed_range" (consider if adding), add a feature test macro, make sure the size wording are as in other similar cases.

Outcome

The next revision should address the design issues mentioned. The name "views::cartesian_product", "cartesian_product_view" was supported.

@inbal2l inbal2l removed the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Jun 1, 2021
@brycelelbach brycelelbach added the IS Ship vehicle: IS label Sep 18, 2021
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Sep 28, 2021
@inbal2l
Copy link
Collaborator

inbal2l commented Oct 11, 2021 •
edited

Paper was seen by SG9 on 2021-10-11
SG9 have requested the following change. The paper should be sent on SG9 ML, and if no objection is brought up, will be forwarded to LEWG (Tomasz has volunteered to help with the wording).

POLL: We want cartisian_product to support special cases specified in section 3.8 of “D2374R2: cartesian_product_view”

SF F N A SA
1 3 2 0 0

Outcome: Consensus for.

@inbal2l
Copy link
Collaborator

inbal2l commented Nov 9, 2021 •
edited

R2 of the paper was seen by SG9 on 2021-11-8. (Full Minutes)
Fixes requested by SG9 last time where implemented, we might want to improve non-user facing concepts' naming.

Polls

POLL: Forward P2374R2 views::cartesian_product to LEWG for C++23

Outcome: No Objection To Unanimous Consent
Attendance: 11
# of Authors: 1

Outcome

R2 of the paper was forwarded to LEWG for C++23.

@brycelelbach brycelelbach added expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll needs-revision Paper needs changes before it can proceed and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. needs-revision Paper needs changes before it can proceed labels Nov 9, 2021
@inbal2l
Copy link
Collaborator

inbal2l commented Nov 10, 2021

R0 was seen by LEWG on 2021-11-09. (Full Minutes)

Polls

POLL: Modify “P23741R2 views::cartesian_product” by specifying the size requirements for the size and difference types as recommended practice and forward to LWG for C++23 with priority level 3 to be confirmed with library evolution electronic poll.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
8 10 1 0 0

Attendance: 26

# of Authors: 1

Author Position: SF

Outcome: Strong Consensus In Favor

Outcome

R2 (+ typos fixes) will be forwarded to LWG for C++23, priority 3 (addition) (to be confirmed with electronic poll).

@jensmaurer jensmaurer removed this from the 2021-telecon milestone Nov 12, 2021
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 6, 2021
@cor3ntin cor3ntin removed the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 7, 2021
@JeffGarland JeffGarland added the LWG Library label Dec 13, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Dec 18, 2021

P2374R2 views::cartesian_product (Sy Brand, Michał Dominiak)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Dec 18, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Dec 18, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Dec 18, 2021

P2374R3 views::cartesian_product (Sy Brand, Michał Dominiak)

@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 19, 2021
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@cor3ntin
Copy link

cor3ntin commented Jan 16, 2022 •
edited by brycelelbach

2021-12 Library Evolution Electronic Poll Outcomes

POLL: Send [P2374R3] (views::cartesian_product) to Library Working Group for C++23, classified as an addition ([P0592R4] bucket 3 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
14 9 0 2 0

Consensus in favor, forwarded to LWG

@cor3ntin cor3ntin removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jan 16, 2022
@jwakely
Copy link
Member

jwakely commented Jul 1, 2022

LWG reviewed this again today and asked for a few more edits. We'll see it again next week.

@jwakely jwakely mentioned this issue Jul 1, 2022
Closed
@JeffGarland JeffGarland added the lwg-fullreview Paper is ready for lwg full group review label Jul 4, 2022
@JeffGarland
Copy link
Member

LWG reviewed and approved 2022-07-08
Notes: https://wiki.edg.com/bin/view/Wg21telecons2022/P2374-20220708

poll: Put p2374r4 into C++23?

F A N
15 0 1

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed lwg-fullreview Paper is ready for lwg full group review B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 size - medium paper size estimate labels Jul 8, 2022
@wg21bot
Copy link
Collaborator Author

wg21bot commented Jul 21, 2022

P2374R4 views::cartesian_product (Sy Brand, Michał Dominiak)

@jensmaurer jensmaurer mentioned this issue Jul 25, 2022
Merged
@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
None yet
Milestone
2022-telecon
Development

Successfully merging a pull request may close this issue.

P2374R4 views::cartesian_product cplusplus/draft
7 participants
@brycelelbach @jwakely @cor3ntin @JeffGarland @inbal2l @jensmaurer @wg21bot