Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2377 [[nodiscard]] in the Standard Library: Clause 23 Iterators library #1047

Closed
wg21bot opened this issue May 21, 2021 · 2 comments
Closed
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list size - small paper size estimate

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented May 21, 2021

P2377R0 [[nodiscard]] in the Standard Library: Clause 23 Iterators library (Christopher Di Bella)

@wg21bot wg21bot added the LEWG Library Evolution label May 21, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone May 21, 2021
@brycelelbach brycelelbach added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS size - medium paper size estimate ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels May 26, 2021
@cor3ntin
Copy link

Mailing list review July 6 - July 22 2021

There was some concern over the wording of the customization point, and I think this needs to be addressed before we can consider forwarding this paper.

People also asked to clarify how much of this paper matches Microsoft's implementation. We also recommend reaching out to libstdc++ implementers for their feedback.
We recommend that someone write a guideline paper to guide future [[nodiscard]] proposals, but also recognize that it sometimes has to be worked-out on a case to case basis.

A lot of discussions about whether this is worth our time.
We seem to be in a catch 22 where some people think [[nodiscard]] should fall strictly under QOI, while some implementations expect [[nodiscard]] to be standardized first.

A few people illustrated cases where users would benefit from [[nodiscard]] being applied.

I am hoping that once the concerns about customization points are addressed, this paper can do a second round of mailing list reviews and then be forwarded through the next round of electronic polling.

@cor3ntin cor3ntin added needs-revision Paper needs changes before it can proceed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list size - small paper size estimate and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting size - medium paper size estimate labels Jul 26, 2021
@jensmaurer jensmaurer removed this from the 2021-telecon milestone Nov 12, 2021
@cor3ntin
Copy link

The author informed me he is not actively pursuing this paper at this time. we will reopen the issue if a new version of the paper is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS LEWG Library Evolution needs-revision Paper needs changes before it can proceed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list size - small paper size estimate
Projects
None yet
Development

No branches or pull requests

4 participants