Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2432 Fix istream_view #1098

Closed
brycelelbach opened this issue Aug 31, 2021 · 6 comments · Fixed by cplusplus/draft#5012
Closed

P2432 Fix istream_view #1098

brycelelbach opened this issue Aug 31, 2021 · 6 comments · Fixed by cplusplus/draft#5012
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges size - small paper size estimate

Comments

@brycelelbach
Copy link

P2432R0 Fix istream_view (Nicolai Josuttis)

@brycelelbach brycelelbach added LEWG Library Evolution C++23 Targeted at C++23 C++20 Targeted at C++20 B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting size - small paper size estimate scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Aug 31, 2021
@brycelelbach brycelelbach added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Sep 9, 2021
@JeffGarland
Copy link
Member

Notes from LEWG discussion.
https://wiki.edg.com/bin/view/Wg21telecons2021/P2432#Library-Evolution-2021-09-09

Due to the breaking changes proposed here LWG will process this prior to the completion of electronic polls

@JeffGarland JeffGarland added LWG Library lwg-fullreview Paper is ready for lwg full group review ranges std::ranges labels Sep 17, 2021
@inbal2l
Copy link
Collaborator

inbal2l commented Sep 18, 2021

As mentioned, R0 was seen by LEWG on 2021-09-09 and forwarded as a DR to C++20

Polls

POLL: Forward P2432 to electronic polling for C++23 as a B2 item and apply it as a DR for C++20

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
7 8 3 1 1

__Attendance:__21

__# of Authors:__1

__Author Position:__SF

Outcome: Consensus in favor

Summary

The paper was approved as a C++23 B2 item (in terms of P0592, see Prioritization for more details), and a C++20 DR.

@JeffGarland
Copy link
Member

JeffGarland commented Sep 24, 2021

LWG reviewed and approved for C++20 DR and C++23 pending approval by LEWG polling.

https://wiki.edg.com/bin/view/Wg21telecons2021/P2432-20210924

poll: put P2432r1 into C++23 as a DR against C++20 assuming LEWG approval

F N A
11 1 0

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed lwg-fullreview Paper is ready for lwg full group review labels Sep 25, 2021
@brycelelbach
Copy link
Author

2021 September Library Evolution Polls

P2451: 2021 September Library Evolution Poll Outcomes

Poll 3: Send P2432R0 (Fix istream_view) to Library Working Group for C++23, classified as an improvement of an existing feature (P0592R4 bucket 2 item), with the recommendation that implementations retroactively apply it to C++20.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
6 8 4 3 1

Outcome: Weak consensus in favor.

Selected Comments

This is an annoying and preventable inconsistency, and we should use the chance to fix this while we still can.

— Strongly Favor

It's unfortunate to do that post-fact, and it should have been fixed years ago, but better have some (controlled) pain now as opposed to ongoing pain over the next decade or so.

— Strongly Favor

I really strongly encourage consistency. This problem will not impact large amount of users, and by the same reasoning, change that late is not breaking a lot of code.

— Weakly Favor

I'm all for fixing C++20 now, before it gets used by lots an lots of people. Adoption is always slow, we can continue to fix things.

— Weakly Favor

SF for adding views::istream. WA on changing istream_view (once we have views::istream, nobody should be using istream_view; it seems unnecessarily breaking all things considered). WF overall.

— Weakly Favor

Consistency by itself is a poor reason to change something in C++20, but given that there are numerous other retroactive changes being made, this change is a reasonable candidate for that set.

— Neutral

Consistency in the standard library would be nice, but [my users] don't care about binary compatibility and will use whatever API is available at the time we need the feature.

— Neutral

These are not things that need to be applied as a DR. We add functions to classes regularly. We add concepts. We even subtly change the results of things like "begin".

In addition, this proposal needs more bake time, particularly since it has substantial chance of breaking things.

— Weakly Against

Changed from Weakly Favor [at the telecon] to Strongly against here. I think the best option is for us to deprecate std::ranges::istream_view and add std::views::istream in its place.

— Strongly Against

@brycelelbach brycelelbach added IS Ship vehicle: IS and removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Sep 25, 2021
@cor3ntin cor3ntin added plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. and removed tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. labels Oct 4, 2021
@wg21bot
Copy link
Collaborator

wg21bot commented Oct 26, 2021

P2432R1 Fix istream_view, Rev 1 (Nicolai Josuttis)

@wg21bot
Copy link
Collaborator

wg21bot commented Oct 26, 2021

Adopted 2021-10.

@jensmaurer jensmaurer removed the C++20 Targeted at C++20 label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges size - small paper size estimate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants