Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2438 std::string::substr() && #1104

Closed
wg21bot opened this issue Sep 20, 2021 · 9 comments · Fixed by cplusplus/draft#5678
Closed

P2438 std::string::substr() && #1104

wg21bot opened this issue Sep 20, 2021 · 9 comments · Fixed by cplusplus/draft#5678
Labels
C++23 Targeted at C++23 expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Milestone
2022-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Sep 20, 2021

P2438R0 std::string::substr() && (Federico Kircheis, Tomasz Kamiński)
@wg21bot wg21bot added LEWG Library Evolution LEWGI Library Evolution Incubator labels Sep 20, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Sep 20, 2021
@jensmaurer jensmaurer changed the title P2438 std::string::substr() && P2438 std::string::substr() && Sep 20, 2021
@brycelelbach brycelelbach added IS Ship vehicle: IS size - medium paper size estimate size - small paper size estimate B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list and removed LEWGI Library Evolution Incubator size - medium paper size estimate labels Sep 24, 2021
@cor3ntin cor3ntin added expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Nov 15, 2021
@brycelelbach
Copy link

brycelelbach commented Nov 16, 2021 •
edited

A Library Evolution motion was made to advance this paper directly to electronic polling on 2021-11-15.

@brycelelbach brycelelbach added expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. and removed expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. labels Nov 16, 2021
@cor3ntin cor3ntin added the ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll label Nov 30, 2021
@cor3ntin
Copy link

cor3ntin commented Nov 30, 2021 •
edited by brycelelbach

Motion passes with 11 votes after the paper was updated to reflect implementation experience. The author is expected to publish the approved version (D2438R1 as a P paper).

@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 6, 2021
@cor3ntin cor3ntin removed the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 7, 2021
@jwakely
Copy link
Member

jwakely commented Dec 9, 2021

Notes for when this reaches LWG:

The feature needs an Annex D entry about the change in behaviour for existing code.

Use Recommended practice: for "implementations should avoid unnecessary allocations". This is a bit tautological, implementations should always prevent unnecessary allocations, everywhere.

@JeffGarland JeffGarland added the LWG Library label Dec 13, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Dec 18, 2021

P2438R1 std::string::substr() && (Federico Kircheis, Tomasz Kamiński)

@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 19, 2021
@jensmaurer jensmaurer added the C++23 Targeted at C++23 label Jan 1, 2022
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@cor3ntin
Copy link

cor3ntin commented Jan 16, 2022 •
edited by brycelelbach

2021-12 Library Evolution Electronic Poll Outcomes

POLL: Send [P2438R1] (string::substr() &&) to Library Working Group for C++23, classified as an improvement of an existing feature ([P0592R4] bucket 2 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
7 18 1 0 0

Strong Consensus in favor, forwarded to LWG

@cor3ntin cor3ntin removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll labels Jan 16, 2022
@cor3ntin cor3ntin removed the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Jan 16, 2022
@tahonermann
Copy link
Collaborator

@cor3ntin, it looks like the wrong poll was quoted in your recently added comment. I didn’t check if the quoted poll numbers are correct.

@cor3ntin
Copy link

@tahonermann thanks, fixed

@JeffGarland
Copy link
Member

JeffGarland commented Feb 4, 2022 •
edited

LWG reviewed and approved this paper for C++23 on 2022-02-04. This will be part of July Plenary.

https://wiki.edg.com/bin/view/Wg21telecons2022/P2438-20220204

poll: move P2438r2 into C++23

F A N
10 0 0

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - small paper size estimate labels Feb 4, 2022
@wg21bot
Copy link
Collaborator Author

wg21bot commented Feb 22, 2022

P2438R2 std::string::substr() && (Federico Kircheis, Tomasz Kamiński)

@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Jul 25, 2022
@jensmaurer jensmaurer mentioned this issue Jul 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
None yet
Milestone
2022-telecon
Development

Successfully merging a pull request may close this issue.

P2438R2 std::string::substr() && cplusplus/draft
7 participants
@brycelelbach @jwakely @cor3ntin @tahonermann @JeffGarland @jensmaurer @wg21bot