Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2446 views::move #1111

Closed
wg21bot opened this issue Sep 20, 2021 · 8 comments · Fixed by cplusplus/draft#5708
Closed

P2446 views::move #1111

wg21bot opened this issue Sep 20, 2021 · 8 comments · Fixed by cplusplus/draft#5708
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Milestone
2022-telecon

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Sep 20, 2021

P2446R0 views::move (Barry Revzin)
@wg21bot wg21bot added the LEWG Library Evolution label Sep 20, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Sep 20, 2021
@cor3ntin cor3ntin added the SG9 Ranges SG label Sep 20, 2021
@inbal2l inbal2l added the ranges std::ranges label Sep 20, 2021
@brycelelbach brycelelbach added C++23 Targeted at C++23 IS Ship vehicle: IS B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 size - medium paper size estimate ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Sep 24, 2021
@brycelelbach brycelelbach added needs-revision Paper needs changes before it can proceed and removed ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting labels Nov 9, 2021
@inbal2l inbal2l removed the SG9 Ranges SG label Nov 10, 2021
@inbal2l
Copy link
Collaborator

inbal2l commented Nov 10, 2021 •
edited

R0 was seen by LEWG on 2021-11-09. (Full Minutes)

Polls

POLL: Modify P2446R0 views::move by changing the name to "all_move".

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
1 9 4 3 0

Attendance: 26

# of Authors: 1

Author Position: N

Outcome: Weak Consensus in Favor

POLL: Modify P2446R0 (views::move) by changing the name to "all_move", add a feature test macro, and then send the revised paper to LWG for C++23 with priority level 3 (to be confirmed with a Library Evolution electronic poll).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
3 10 5 0 0

Attendance: 26

# of Authors: 1

Author Position: F

Outcome: Consensus in Favor

Outcome

Forwarded with the fixes: change the name to "all_move", add a feature test macro, then send the new revision to LWG for C++23 as priority 3 item (to be confirmed with a Library Evolution electronic poll)

@jensmaurer jensmaurer removed this from the 2021-telecon milestone Nov 12, 2021
@wg21bot
Copy link
Collaborator Author

wg21bot commented Nov 26, 2021

P2446R1 views::all_move (Barry Revzin)

@wg21bot wg21bot removed the needs-revision Paper needs changes before it can proceed label Nov 26, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Nov 26, 2021
@inbal2l inbal2l added the ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll label Nov 26, 2021
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 6, 2021
@cor3ntin cor3ntin removed the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 7, 2021
@JeffGarland JeffGarland added the LWG Library label Dec 13, 2021
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 19, 2021
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@cor3ntin
Copy link

cor3ntin commented Jan 16, 2022 •
edited by brycelelbach

2021-12 Library Evolution Electronic Poll Outcomes

POLL: Send [P2446R1] (views::all_move) to Library Working Group for C++23, classified as an addition ([P0592R4] bucket 3 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
9 9 1 3 0

Consensus in favor, forwarded to LWG

@cor3ntin cor3ntin removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jan 16, 2022
@wg21bot
Copy link
Collaborator Author

wg21bot commented Feb 22, 2022

P2446R2 views::as_rvalue (Barry Revzin)

@JeffGarland
Copy link
Member

Adding LWG notes from 2022-01-04

https://wiki.edg.com/bin/view/Wg21telecons2022/P2446-20220114

poll: put p2446r2 into C++23? JW reviewing the changes

F A N
12 0 0

@JeffGarland JeffGarland added the tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. label Apr 10, 2022
@brycelelbach
Copy link

2022-05-31 Library Evolution Telecon

P2278R3: cbegin should always return a constant iterator

2022-05-31 Library Evolution Telecon Minutes

P2446R2: views::as_rvalue

2022-05-31 Library Evolution Telecon Minutes

Chair: Bryce Adelstein Lelbach

Minute Taker: Dietmar Kühl

Champion: Barry Revzin

Start: 2022-05-31 11:45 Eastern

Proposal is to call these adaptors as_const and as_rvalue (previously all_const and all_move).

We seem to be onboard with these names, we will start a mailing list motion to confirm the change.

End: 11:48

Summary

We discussed a solution to the naming of the adaptors previously known as all_const and all_move.
The suggested new names are as_const (which was its original name) and as_rvalue.

Library Evolution had broad support for these names.

Next Steps

  • Start a mailing list motion to confirm renaming all_const to as_const (from P2278R3) and all_move to as_rvalue (from P2446R2).
  • Assuming the mailing list motion is successful, take an electronic poll to confirm returning them to Library for C++23.

@brycelelbach brycelelbach added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll LEWG Library Evolution labels Jun 17, 2022
@brycelelbach
Copy link

A Library Evolution mailing list motion was started on 2022-06-07 to approve the renaming of all_const to as_const (from P2278R3) and all_move to as_rvalue (from P2446R2). The motion passed.

@brycelelbach brycelelbach mentioned this issue Jun 19, 2022
Closed
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Jun 29, 2022
@brycelelbach brycelelbach added the lwg-pending LWG Chair needs to disposition label Jul 8, 2022
@JeffGarland JeffGarland removed lwg-pending LWG Chair needs to disposition B3 - addition Bucket 3 as described by P0592: material that is not mentioned in P0592 size - medium paper size estimate labels Jul 8, 2022
@brycelelbach
Copy link

2022-07 Library Evolution Electronic Poll Outcomes

Poll 1.6: Send [P2446R2] views::as_rvalue to Library Working Group for C++23, classified as an addition ([P0592R4] bucket 3 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
15 7 0 1 0

Outcome: Consensus in favor.

@brycelelbach brycelelbach removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jul 22, 2022
@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Jul 25, 2022
@jensmaurer jensmaurer mentioned this issue Aug 4, 2022
Merged
@brevzin brevzin mentioned this issue Feb 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. ranges std::ranges tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
None yet
Milestone
2022-telecon
Development

Successfully merging a pull request may close this issue.

P2446R2 views::as_rvalue cplusplus/draft
6 participants
@brycelelbach @cor3ntin @JeffGarland @inbal2l @jensmaurer @wg21bot