Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2460 Relax requirements on wchar_t to match existing practices #1122

Closed
wg21bot opened this issue Oct 26, 2021 · 12 comments · Fixed by cplusplus/draft#5674
Closed

P2460 Relax requirements on wchar_t to match existing practices #1122

wg21bot opened this issue Oct 26, 2021 · 12 comments · Fixed by cplusplus/draft#5674
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 CWG Core expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. IS Ship vehicle: IS LWG Library lwg-fullreview Paper is ready for lwg full group review plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate straw-poll Straw poll tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
Milestone

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Oct 26, 2021

P2460R0 Relax requirements on wchar_t to match existing practices (Corentin Jabot)

@wg21bot wg21bot added EWG Evolution LEWG Library Evolution SG22 C / C++ liaison labels Oct 26, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Oct 26, 2021
@tahonermann
Copy link
Collaborator

SG16 discussed P2460R0 during its 2021-10-06 telecon. The following poll was taken:

  • Poll 1: Add expanded motivation to D2460R0 and forward the paper so revised to EWG
    with a recommended ship vehicle of C++23.
    • Attendance: 10

      SF F N A SA
      5 3 1 0 0
    • Strong consensus in favor.

This paper is now ready for review by EWG and LEWG.

Review by EWG is necessary because this paper relaxes current core language restrictions.

Review by LEWG is necessary because this paper transfers the prior core language restrictions to library functions that accept a wide string. This paper arguably introduces a new form of library UB because a library function accepting a wide string may now encounter a wide string for which some code units of the string do not directly encode a character (e.g., a code unit could now specify a UTF-16 surrogate).

@brycelelbach brycelelbach added size - small paper size estimate B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e IS Ship vehicle: IS C++23 Targeted at C++23 expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Oct 31, 2021
@brycelelbach
Copy link

brycelelbach commented Oct 31, 2021

@brycelelbach brycelelbach added ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Nov 1, 2021
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Nov 9, 2021
@cor3ntin cor3ntin added LWG Library and removed ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review LEWG Library Evolution expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. labels Dec 6, 2021
@cor3ntin
Copy link

cor3ntin commented Dec 6, 2021

2021-11 Library Evolution Electronic Poll Outcomes

Poll 1: Send [P2460R0] (Relax Requirements On wchar_t To Match Existing Practices) to Library Working Group for C++23, classified as an improvement of an existing feature ([P0592R4] bucket 2 item).

SF F N A SA
12 15 1 1 0

Consensus in favor

@AaronBallman
Copy link
Collaborator

AaronBallman commented Dec 13, 2021

This paper was discussed at the Dec 2021 SG22 meeting.

Poll: SG22 does not see any compatibility concerns for the direction of P2460r0 in C++.
Attendees: 10
No objection to unanimous consent

Removing the SG22 tag.

@AaronBallman AaronBallman removed the SG22 C / C++ liaison label Dec 13, 2021
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@brycelelbach
Copy link

Note that this needs to be reviewed by EWG before it is approved.

@brycelelbach brycelelbach added the expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. label Feb 23, 2022
@erichkeane
Copy link
Collaborator

Please discuss this in SG22 for awareness (non-blocking).

@erichkeane erichkeane added the SG22 C / C++ liaison label Apr 28, 2022
@erichkeane
Copy link
Collaborator

EWG reviewed P2460R0during its 2022-4-08 telecon, the following poll was taken:

Send P2460R0 to electronic polling for forwarding to CWG as a defect report against all versions of the C++ standard to which it applies.

SF F N A SA
9 8 0 0 1

Result: Consensus

Paper forwarded to electronic polling.

@erichkeane erichkeane added EWG-vote-on-me EWG can vote on this and removed EWG Evolution labels Apr 28, 2022
@AaronBallman AaronBallman removed the SG22 C / C++ liaison label May 21, 2022
@AaronBallman
Copy link
Collaborator

Removing the SG22 label -- we had reviewed it before at our Dec 2021 meeting.

@wg21bot
Copy link
Collaborator Author

wg21bot commented May 24, 2022

P2460R1 Relax requirements on wchar_t to match existing practices (Corentin Jabot)

@jensmaurer
Copy link
Member

CWG telecon 2022-06-17: Reviewed P2460R1; approved for plenary, pending LWG approval.

@JeffGarland JeffGarland added the lwg-pending LWG Chair needs to disposition label Jul 6, 2022
@jfbastien
Copy link
Collaborator

This was voted on in the June 2022 EWG polls. Results are here.

  • 🗳 Poll: Forward P2460r1 "Relax requirements on wchar_t to match existing practices" to CWG for C++23, treat it as a Defect Report.

Poll votes:

SF F N A SA
10 12 1 1 1
Abstain: 3


Poll outcome: ✅ consensus

@jfbastien jfbastien added CWG Core and removed EWG-vote-on-me EWG can vote on this labels Jul 10, 2022
@jensmaurer jensmaurer added this to Approved for plenary vote in CWG Jul 10, 2022
@JeffGarland JeffGarland added lwg-fullreview Paper is ready for lwg full group review and removed lwg-pending LWG Chair needs to disposition labels Jul 13, 2022
@jensmaurer jensmaurer added the straw-poll Straw poll label Jul 15, 2022
@wg21bot
Copy link
Collaborator Author

wg21bot commented Jul 21, 2022

P2460R2 Relax requirements on wchar_t to match existing practices (Corentin Jabot)

@cor3ntin cor3ntin added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. labels Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 CWG Core expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. IS Ship vehicle: IS LWG Library lwg-fullreview Paper is ready for lwg full group review plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate straw-poll Straw poll tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
CWG
Approved for plenary vote
Development

Successfully merging a pull request may close this issue.

9 participants