Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2505 Monadic Functions for std::expected #1161

Closed
wg21bot opened this issue Dec 18, 2021 · 15 comments · Fixed by cplusplus/draft#5993
Closed

P2505 Monadic Functions for std::expected #1161

wg21bot opened this issue Dec 18, 2021 · 15 comments · Fixed by cplusplus/draft#5993
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library lwg-fullreview Paper is ready for lwg full group review plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate
Milestone
2022-11

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Dec 18, 2021

P2505R0 Monadic Functions for std::expected (Jeff Garland)
@wg21bot wg21bot added LEWG Library Evolution LWG Library labels Dec 18, 2021
@wg21bot wg21bot added this to the 2021-telecon milestone Dec 18, 2021
@JeffGarland JeffGarland added the C++23 Targeted at C++23 label Dec 18, 2021
@brycelelbach brycelelbach added B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list size - small paper size estimate IS Ship vehicle: IS and removed LWG Library labels Dec 22, 2021
@inbal2l inbal2l added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Dec 22, 2021
@jensmaurer jensmaurer modified the milestones: 2021-telecon, 2022-telecon Jan 1, 2022
@inbal2l inbal2l added the expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. label Jan 11, 2022
@brycelelbach
Copy link

brycelelbach commented Jan 17, 2022 •
edited

A Library Evolution motion was made to advance this paper directly to electronic polling on 2022-01-11. During the discussion, design questions were raised which remained unresolved at the start of the next electronic polling period. The motion failed on 2022-01-17.

@brycelelbach brycelelbach removed the expedited-library-evolution-electronic-poll Papers that were reviewed on the mailing list and then advanced directly to electronic polling. label Jan 17, 2022
@brycelelbach brycelelbach added C++26 Targeted at C++26 and removed C++23 Targeted at C++23 labels Feb 1, 2022
@brycelelbach
Copy link

Deferred to C++26.

@brycelelbach brycelelbach removed the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Feb 1, 2022
@wg21bot
Copy link
Collaborator Author

wg21bot commented Feb 22, 2022

P2505R1 Monadic Functions for std::expected (Jeff Garland)

@brycelelbach brycelelbach added ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review and removed ready-for-library-evolution-mailing-list-review This paper needs to be discussed on the Library Evolution mailing list labels Apr 1, 2022
@wg21bot
Copy link
Collaborator Author

wg21bot commented Apr 25, 2022

P2505R2 Monadic Functions for std::expected (Jeff Garland)

@Zingam Zingam mentioned this issue Apr 25, 2022
Merged
@brycelelbach brycelelbach added C++23 Targeted at C++23 and removed C++26 Targeted at C++26 labels Apr 25, 2022
@brycelelbach
Copy link

This is being considered for C++23, at the request of some members, who consider it a bug fix.

@ben-craig
Copy link
Collaborator

ben-craig commented May 9, 2022 •
edited by brycelelbach

P2505R2: Monadic Functions for std::expected

P2505R2: Monadic Functions for std::expected

2022-05-03 Library Evolution Telecon Minutes

Chair: Ben Craig

Minute Taker: Mark Hoemmenn

Champion: Barry Revzin

Summary

Went carefully through the API. Here are some of the notes that I highlighted.

Deducing this would allow us to constrain on invocability.

transform_error else should use the unexpect constructor.

Corner case, transform. If I return unexpect from my invocable, maybe say function can't return unexpect?

Should mandate that none of the functions can return unexpect.

transform_error should move from from error in the void specialization.

Contention around free functions vs. member functions.

Next Steps

Revise the paper and bring it back to LEWG

@brycelelbach brycelelbach removed the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Jun 2, 2022
@jwakely
Copy link
Member

jwakely commented Sep 6, 2022

Scheduled for LWG telecon tomorrow. See the mailing list for details.

@JeffGarland JeffGarland added lwg-fullreview Paper is ready for lwg full group review and removed lwg-pending LWG Chair needs to disposition labels Sep 6, 2022
@BowenFu BowenFu mentioned this issue Sep 11, 2022
Merged
@jwakely
Copy link
Member

jwakely commented Sep 28, 2022

LWG completed the review of P2505R5 and approved it for the working draft, once it's open for new additions again.

@jensmaurer jensmaurer added C++26 Targeted at C++26 and removed C++23 Targeted at C++23 labels Sep 28, 2022
@jensmaurer
Copy link
Member

Moved to C++26 for now.

@wg21bot
Copy link
Collaborator Author

wg21bot commented Oct 17, 2022

P2505R5 Monadic Functions for std::expected (Jeff Garland)

This was referenced Oct 26, 2022
Closed
Closed
@brycelelbach brycelelbach added LEWG Library Evolution C++23 Targeted at C++23 LWG Library and removed LWG Library C++26 Targeted at C++26 labels Nov 3, 2022
@brycelelbach brycelelbach changed the title P2505 Monadic Functions for std::expected C++23 Nov 3, 2022
@brycelelbach brycelelbach changed the title C++23 P2505 Monadic Functions for std::expected Nov 3, 2022
@brycelelbach brycelelbach added the ready-for-library-evolution-meeting-review This paper needs to be discussed at a Library Evolution meeting label Nov 4, 2022
@brycelelbach brycelelbach mentioned this issue Nov 4, 2022
Closed
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Nov 7, 2022
@brycelelbach
Copy link

brycelelbach commented Nov 10, 2022 •
edited by FabioFracassi

2022-11-07 10:00 to 11:30 UTC-10 Kona Library Evolution Meeting

P2505R5: Monadic functions for expected

2022-11-07 10:00 to 11:30 UTC-10 Kona Library Evolution Minutes

Champion: Jeff Garland (in-person)

Chair: Fabio Fracassi & Billy Baker

Minute Taker: Steve Downey

POLL: Adopt P2505R5 for C++23 (LWG already reviewed and approved this version)

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
11 12 1 0 0

Attendance: 28 19 + 9

# of Authors: 1

Author Position: SF

Outcome: Strong consensus in favour

Summary

We consider this to be a consistency fix.

Next Steps

Send to LWG

@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Nov 12, 2022
@jensmaurer jensmaurer mentioned this issue Nov 20, 2022
Merged
@wroyca wroyca mentioned this issue Nov 30, 2022
Closed
@jensmaurer jensmaurer modified the milestones: 2022-telecon, 2022-11 Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library lwg-fullreview Paper is ready for lwg full group review plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. size - small paper size estimate
Projects
2022-11 Kona Library Evolution Agenda
Status: Done
Milestone
2022-11
Development

Successfully merging a pull request may close this issue.

[Motions 2022 11 lwg 13] P2505R5 Monadic Functions for std::expected RobertLeahy/draft
8 participants
@brycelelbach @ben-craig @jwakely @cor3ntin @JeffGarland @inbal2l @jensmaurer @wg21bot