Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2604 mdspan: rename pointer and contiguous #1258

Closed
brycelelbach opened this issue Jun 21, 2022 · 4 comments
Closed

P2604 mdspan: rename pointer and contiguous #1258

brycelelbach opened this issue Jun 21, 2022 · 4 comments
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library mdspan plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.

Comments

@brycelelbach
Copy link

P2604R0 mdspan: rename pointer and contiguous (Christian Trott)
@brycelelbach brycelelbach added LEWG Library Evolution C++23 Targeted at C++23 IS Ship vehicle: IS B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - small paper size estimate labels Jun 21, 2022
@brycelelbach
Copy link
Author

2022-06-21 Library Evolution Telecon

P2604R0: mdspan: rename pointer, data, and contiguous

2022-06-21 Library Evolution Telecon Minutes

Chair: Bryce Adelstein Lelbach

Minute Taker: Ben Craig

Champion: Christian Trott

Start: 2022-06-21 11:45 Eastern

POLL: Send P2604R0 (mdspan: rename pointer, data, and contiguous) to Library for C++23 classified as B2 - Improvement, to be confirmed with a Library Evolution electronic poll.

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
7 3 1 1 0

Attendance: 30

# of Authors: 1

Author Position: SF

Outcome: Strong consensus in favor.

WA: Ongoing mailing list discussion.

End: 11:50

Summary

During review of mdspan, Library suggested that we should rename pointer, data, and contiguous, as the use of these names overloads some existing meanings in the Standard Library and may lead to confusion.
The authors investigated alternative names, and proposed them in this paper.
Library Evolution was in favor of making the name changes.

Next Steps

Take an electronic poll to confirm sending P2604R0 (mdspan: rename pointer, data, and contiguous) to Library for C++23 classified as B2 - Improvement.

@brycelelbach brycelelbach added the ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll label Jun 21, 2022
@brycelelbach brycelelbach added the scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review label Jun 29, 2022
@brycelelbach brycelelbach added LWG Library lwg-pending LWG Chair needs to disposition labels Jul 8, 2022
@JeffGarland
Copy link
Member

LWG reviewed and approved 2022-06-24

Notes: https://wiki.edg.com/bin/view/Wg21telecons2022/P2604-20220624
poll: Put P2604R0 into C++23 pending LEWG approval

F A N
17 0 0

@JeffGarland JeffGarland added tentatively-ready-for-plenary Reviewed between meetings; ready for a vote. and removed lwg-pending LWG Chair needs to disposition B2 - improvement Bucket 2 as described by P0592: bug fixes, performance improvements, integration fixes for/between e size - small paper size estimate labels Jul 8, 2022
@brycelelbach
Copy link
Author

2022-07 Library Evolution Electronic Poll Outcomes

Poll 1.13: Send [P2604R0] mdspan: Rename pointer, data, And contiguous to Library Working Group for C++23, classified as an improvement of an existing feature ([P0592R4] bucket 2 item).

Strongly Favor Weakly Favor Neutral Weakly Against Strongly Against
13 13 0 0 0

Outcome: Unanimous consensus in favor.

@brycelelbach brycelelbach removed LEWG Library Evolution ready-for-library-evolution-electronic-poll This paper needs to undergo a Library Evolution electronic poll scheduled-for-library-evolution This paper has been scheduled for one of the groups: LEWG, LEWG Incubator, or a Mailing List review labels Jul 22, 2022
@cor3ntin cor3ntin added the plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. label Jul 25, 2022
@jensmaurer jensmaurer mentioned this issue Jul 29, 2022
Closed
@tkoeppe
Copy link

tkoeppe commented Aug 11, 2022

This has been applied.

@tkoeppe tkoeppe closed this as completed Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++23 Targeted at C++23 IS Ship vehicle: IS LWG Library mdspan plenary-approved Papers approved for inclusion in their target vehicle by plenary vote. tentatively-ready-for-plenary Reviewed between meetings; ready for a vote.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brycelelbach @cor3ntin @JeffGarland @tkoeppe