[vector.bool] Excise use of undefined term 'conversion operator' #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
reviewed
Nov 13, 2016
| @@ -1289,7 +1289,7 @@ | |||
| \ref{istream::sentry}, | |||
| \ref{ostream::sentry}, | |||
| \ref{iostate.flags} | |||
| \change Specify use of explicit in existing boolean conversion operators | |||
| \change Specify use of explicit in existing boolean conversion functions | |||
There was a problem hiding this comment.
Should "explicit" appear in code font, since it's actually a keyword?
There was a problem hiding this comment.
Yes, but I shouldn't make that change here, which deals with "conversion operator" vs. "conversion function".
I've created #1019 to deal with the "explicit" code font issue.
There was a problem hiding this comment.
OK, sure, but I would have had no problem with a minor drive-by fix like that if this is a single, isolated problem. You can stick it into a separate commit in the same pull request, and I could retain the separate commits (i.e. not squash them), so we still get nicely atomic commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #444.