[atomics] Clean up indexing of atomics clause #1038
Conversation
| @@ -427,6 +427,7 @@ | |||
|
|
|||
| \rSec1[atomics.types.generic]{Atomic types} | |||
|
|
|||
| \indexlibrary{\idxcode{atomic<\placeholder{type}>}}% | |||
There was a problem hiding this comment.
For the primary template, we just use \indexlibrary{\idxcode{atomic}}%
There was a problem hiding this comment.
Maybe index entries for atomic<integral> and atomic<T*> might make sense, though.
There was a problem hiding this comment.
Replaced all uses of atomic with just atomic, where appropriate to that type. Added fresh entries for atomic and atomic<T*>, to better index their larger interfaces. Then removed any remaining references to atomic.
| @@ -763,7 +808,7 @@ | |||
| operations on non-volatile objects become volatile. Thus, volatile qualified operations | |||
| on non-volatile objects may be merged under some conditions. \end{note} | |||
|
|
|||
| \indexlibrary{\idxcode{atomic type}!constructor}% | |||
| \indexlibrary{\idxcode{atomic<\placeholder{type}>}!constructor}% | |||
There was a problem hiding this comment.
Likewise here, just \indexlibrary{\idxcode{atomic}!constructor}% would be in line with what we do elsewhere.
|
Please also fix the commit message to refer to the clause's stable name. |
AlisdairM
force-pushed
the
index_review_clause_29
branch
from
6fd2ac6
to
e56ff54
Compare
tkoeppe
force-pushed
the
master
branch
2 times, most recently
from
d2a10b4
to
c1f9b30
Compare
AlisdairM
force-pushed
the
index_review_clause_29
branch
from
e56ff54
to
963155d
Compare
AlisdairM
changed the title
AlisdairM
force-pushed
the
index_review_clause_29
branch
from
963155d
to
094a5f1
Compare
|
Rebased onto current master and pushed again, with updated headline as requested by @tkoeppe. This patch has some additional index entries that I had missed on the first pass, and makes some (but not exhaustive) tweaks in the main text to use \placeholder for consistency with the indexed use. It is probably worth a fresh review, rather than just comparing to changes in the last one. |
|
Are you still around for a final rebase? |
Reverse class/member names in indexlibrarymember macros to be consistent with the prefered style in other clauses. Expand in the index several functions that are documented as a pattern-match, such as fetch_add and fetch_sub. Replace 'atomic type' for index references with either just 'atomic', 'atomic<integral>', or 'atomic<T*>' to follow existing conventions for documenting templates, and to more clearly call out the larger interfaces of the defined specializations. Added further indexing for a few items that had missed index entries in the first pass.
AlisdairM
force-pushed
the
index_review_clause_29
branch
from
094a5f1
to
0072e5a
Compare
|
Rebased and pushed. |
Reverse class/member names in indexlibrarymember macros to be
consistent with the prefered style in other clauses.
Expand in the index several functions that are documented as a
pattern-match, such as fetch_add and fetch_sub.
Use 'atomic' rather than 'atomic type' for index references
to the atomic template. This allows for a more intuitive indexing
of the conversion operator.