Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp.replace] Delete obsolete footnote #1045

Merged
merged 1 commit into from Nov 28, 2016

Conversation

timsong-cpp
Copy link
Contributor

@timsong-cpp timsong-cpp commented Nov 14, 2016

non-directive is not a thing anymore (renamed to conditionally-supported-directive by CWG 2001) and the new name makes it clear that it's a directive.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 17, 2016

@hubert-reinterpretcast: Could you please review this PR?

@hubert-reinterpretcast
Copy link
Contributor

The footnote is indeed obsolete in its clarification on the terminology.

I believe a note remains necessary to clarify that tokens that would otherwise be instances of unsupported conditionally-supported-directive still "otherwise act as preprocessing directives" (because they would have required a diagnostic). In the alternative, implementations should not fail compilation on what may be interpreted as an unsupported conditionally-supported-directive within the list of arguments; they would either need to treat the tokens in question as "plain" tokens, or (to fail compilation) they would instead have to document support for all forms of conditionally-supported-directive which they do not intend to support as having semantics amounting to "causes the program to be ill-formed". @zygoloid: comments?

@zygoloid
Copy link
Member

Hubert, would you be looking for an alternative footnote such as "A conditionally-supported-directive is a directive regardless of whether the implementation supports it." ?

I think that makes sense given the context ("[a sequence of tokens] that would act as a preprocessing directive").

@hubert-reinterpretcast
Copy link
Contributor

Yes, something like the suggested alternative footnote would be fine.

…-directives are directives whether supported or not
@timsong-cpp
Copy link
Contributor Author

Force-pushed a new version that replaces the footnote with @zygoloid's wording.

@zygoloid zygoloid merged commit 6a76842 into cplusplus:master Nov 28, 2016
@timsong-cpp timsong-cpp deleted the patch-3 branch November 28, 2016 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants