Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basic] Replace \term with \defnx as appropriate #1061

Merged
merged 1 commit into from Nov 17, 2016

Conversation

jensmaurer
Copy link
Member

Partially addresses #329.

Also removes \term from the introductory note in 3p1 and uses \defnx instead of separate \term and \indextext where applicable.

diffpdf shows only whitespace differences in the main body, plus one slightly moved footnote. The index has a few more entries now, e.g. for "object, const".

@jensmaurer
Copy link
Member Author

One \term{object type} remains, because there is a separate issue about incompatible duplicate definitions of "object type".

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 17, 2016

Are you sure this doesn't clash with #980?

@@ -3595,8 +3589,8 @@
The \defn{object representation}
\indextext{representation!object}%
of an object of type \tcode{T} is the
sequence of \term{N} \tcode{unsigned} \tcode{char} objects taken up
by the object of type \tcode{T}, where \term{N} equals
sequence of \placeholder{N} \tcode{unsigned} \tcode{char} objects taken up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I would probably use maths here, $n$, but that's not so important. We can revisit that as part of #1060.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the "N" here being a code placeholder.

object type is unknown.}
Incompletely-defined object types and \cv\ \tcode{void} are \term{incomplete
types}~(\ref{basic.fundamental}). Objects shall not be defined to have an
Incompletely-defined object types and \cv\ \tcode{void} are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use \cv{} here like elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. The "\cv\ " was already there, and I didn't touch it (because I was replacing \term).
If we want to do the replacement, it's a script job (29 occurrences).

Copy link
Contributor

@tkoeppe tkoeppe Nov 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more like that we don't actively want to spend time on it, but if there's a chance for a drive-by fix, it's usually good to make small improvements. On the other hand, if you have limitless time and would like to do things systematically, even better :-)

represents an arbitrary set of cv-qualifiers, i.e., one of
\{\tcode{const}\}, \{\tcode{volatile}\}, \{\tcode{const},
\tcode{volatile}\}, or the empty set.
\indextext{cv-qualifier!top-level}
For a type \cv\ \tcode{T}, the \term{top-level cv-qualifiers}
For a type \cv\ \tcode{T}, the \defnx{top-level cv-qualifiers}{cv-qualifier!top-level}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, \cv{}.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 17, 2016

Very nice change, I'll be happy to merge this pending comment resolution.

@jensmaurer
Copy link
Member Author

Sorry for the duplicate work; this is likely to clash / be redundant with #980.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 17, 2016

That's OK. I like this PR because it is small and understandable. I'd be happy to apply this; the others need rebasing anyway, so identical, duplicate changes will just go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants