Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17-30] Create index entries for all namespaces #1078

Closed
wants to merge 1 commit into from

Conversation

AlisdairM
Copy link
Contributor

Index each library namespace, and the reserved posix namespace.
Note that many entries for literals namespaces are added after
the header syonpsis, as typically they are the last entries in
that synposis, and the index will find them much more easily
here. Indexing inside the synopsis is avoided, as it leads to
duplicate index entries.

Index each library namespace, and the reserved posix namespace.
Note that many entries for literals namespaces are added after
the header syonpsis, as typically they are the last entries in
that synposis, and the index will find them much more easily
here.  Indexing inside the synopsis is avoided, as it leads to
duplicate index entries.
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 19, 2016

Hm, do you think it's useful to index "namespace std"? Isn't all of the library in that namespace. I'm not sure... let me know you think this really adds value.

@AlisdairM
Copy link
Contributor Author

I index the clause 17 wording on use and requirements on namespace std. It is a standard library (reserved) name and belongs in the index, without going crazy and listing every library page.

Collecting all the subnamespaces under 'std' in one place (in the index) also seemed quite useful to me. Finally, indexing the literals namespaces was a little more interesting, given their structure, but I think I hit a happy medium.

@jensmaurer jensmaurer changed the title [17-30] Create index entrie for all namespaces [17-30] Create index entries for all namespaces Nov 22, 2016
@@ -381,6 +381,9 @@
}
}
\end{codeblock}
\indexlibrary{\idxcode{std}!\idxcode{literals}}%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I can understand where you're coming from, trying to group the sub-namespaces together under the std index entry, but I don't think that's useful to someone looking up the namespace (I would look for complex_literals, not for std, when looking for the complex_literals namespace), and I don't think a particular entry in the index of library names is the right place for a description of the namespace structure of the library. If we want such a description, it should probably go in a subclause of [organization] instead (but it's not obvious to me who the audience for such a description would be).

This approach creates five index entries:

  • std, literals
  • std, complex_literals
  • complex_literals, std
  • std::literals, complex_literals
  • complex_literals, std::literals

I don't really like any of these, and we don't index literals at all this way. I think what we want would be either:

  • literals, complex_literals
  • complex_literals, literals

or

  • literals
  • complex_literals, literals

I would index this as just \indexlibrarymember{literals}{complex_literals}; that seems most consistent with what we do for class members.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 30, 2016

@AlisdairM: Do you have any plans to revise and rework this, or should we just close it?

@AlisdairM
Copy link
Contributor Author

Sorry, I plan to revise this when I get back from current road trip.

@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 4, 2017

@AlisdairM: How's the road trip going? Are you still interested in revising this?

@AlisdairM
Copy link
Contributor Author

Sorry - yes, I want to revive it, but working out the best way to respond to feedback.
I may break it apart to simpler pull requests. I think indexing namespace 'std' and 'posix' in clause 17 should be simple, and I hope non-controversial. Indexing all of the literals namespaces is probably trickier to get the right balance. The other namespaces fall somewhere in-between.

@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 15, 2017

Please reopen if needed and when ready (or send new, smaller PRs instead).

@tkoeppe tkoeppe closed this Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants