[styles] Give lists uniform vertical spacing. #1097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zygoloid, @burblebee: I extracted just the list changes; please have a look. |
|
@zygoloid: This change should avoid all the problems with the previous proposal. The question now boils down to a simpler one of whether we like the tigher and more uniform list spacing. There are two reasons that make me think so:
Please remember that second-level lists may look too tight (just as in the status quo in fact) unless you fix up your memoir.cls. |
tkoeppe
force-pushed
the
style2
branch
6 times, most recently
from
67070d2
to
45d4822
Compare
This change makes it so that the vertical space surrounding lists is independent of whether there is a paragraph break before the list (by setting partopsep to zero). Moreover, all nested lists now use the same vertical spacing, which in turn is the same as the paragraph spacing. There is a bug in memoir that may cause second-level lists (lists within a top-level list) to be rendered too tightly (because the itemsepii length is ignored). This can be fixed locally, though.
|
I'm closing this PR in favour of PR #1134, which uses the |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that the vertical space surrounding lists is independent of whether there is a paragraph break before the list (by setting partopsep to zero).
Moreover, all nested lists now use the same vertical spacing, which in turn is the same as the paragraph spacing.
There is a bug in memoir that may cause second-level lists (lists within a top-level list) to be rendered too tightly (because the itemsepii length is ignored). This can be fixed locally, though.