Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basic.scope.class] Use a regular itemize environment instead of enumeraten #1102

Closed
wants to merge 1 commit into from

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Nov 23, 2016

diffs

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 23, 2016

@zygoloid: Your favourite language concept -- care to review this?

@sigfpe
Copy link

sigfpe commented Nov 23, 2016

Why?

@Eelis
Copy link
Contributor Author

Eelis commented Nov 23, 2016

Oh, I just noticed that all other lists use the styling with "(x.y)" numbers in the margin. If there's a subtle reason for this list to be an anomaly, please close, and in that case my apologies for the noise. :) (In that case, it might be worth documenting that reason in the source code.)

@sigfpe
Copy link

sigfpe commented Nov 23, 2016

Why special-case this paragraph?

@Eelis
Copy link
Contributor Author

Eelis commented Nov 23, 2016

@sigfpe Are you aware that your replies are creating rather spammy-looking comments in the github thread at #1102 ?

@jwakely
Copy link
Member

jwakely commented Nov 23, 2016

That's the point. Currently it's a special case, the change makes it consistent with the rest of the standard.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 23, 2016

I'm generally in favour of having fewer different stylistic elements, and this generally looks like the right direction. Ordered lists are very rare and should only be used when something really needs to be done in order (e.g. translation phases).

@jwakely
Copy link
Member

jwakely commented Nov 23, 2016

The spammy-looking comments come from replying by email rather than on the website. I've edited them to remove the noise.

@Eelis
Copy link
Contributor Author

Eelis commented Nov 23, 2016

Ah I see, cheers!

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 23, 2016

@Eelis: Can you take a look at the other \enumeraten in iostreams? Maybe we can kill that environment with fire.

@sigfpe
Copy link

sigfpe commented Nov 23, 2016

I am not sure I follow.  The (x.y) style was introduced so that we can tell that bullet y is within paragraph x, when referenced. Why is this in the "right sirection"?

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 23, 2016

@sigfpe: There's nothing inherently ordered about the items in question, so a regular list seems like the natural choice here. The "right direction" is to remove stylistic deviations like this.

It might be interesting to trace the origin of this section; does anyone have the ARM at hand?

@Eelis
Copy link
Contributor Author

Eelis commented Nov 23, 2016

Hmm, I just noticed that the only difference between "enumeraten" and "enumerate" is that the former uses "1)" while the latter uses "1." for the item number.

So perhaps a less controversial path forward is to first replace all two "enumeraten" occurrences with "enumerate" (a minimal stylistic change). Then, we can separately decide which "enumerate" occurrences should become "itemize" (a somewhat semantic change).

@sigfpe
Copy link

sigfpe commented Nov 23, 2016 via email

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 23, 2016

@sigfpe: I don't understand - nobody is proposing an enumeration. We're proposing removing an enumeration and replacing it with an itemization.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 23, 2016

@Eelis: yes, perhaps that'd be a start. Enumerations are so rare that we should probably not need to have more than one stylistic component for them.

@sigfpe
Copy link

sigfpe commented Nov 23, 2016 via email

@Eelis
Copy link
Contributor Author

Eelis commented Nov 23, 2016

Now that #1105 was merged, we can start to consider more generally which enumerations should be replaced with itemizations, but this pull request is not the best place for that. Closing.

@Eelis Eelis closed this Nov 23, 2016
@Eelis Eelis deleted the itemenum branch November 23, 2016 19:35
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 23, 2016

@Eelis: We could still try to get rid of enumeratea. If you like, maybe have a look at numerics.tex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants