[diff] Miscellaneous fixes. #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently end the 'Changes' phrase with a period. Add missing newlines. Remove spurious 'Rationale' item. Fix typos. Fixes cplusplus#214.
tkoeppe
reviewed
Nov 26, 2016
|
|
||
| \ref{basic.start} | ||
| \change Main cannot be called recursively and cannot have its address taken | ||
| \change The \tcode{main} function cannot be called recursively and cannot have its address taken. |
There was a problem hiding this comment.
I would even delete the word "recursively". But I suppose this is non-normative, so no big deal.
There was a problem hiding this comment.
I didn't want to change more than necessary to get the formatting non-awkward.
tkoeppe
reviewed
Nov 26, 2016
| @@ -60,7 +60,7 @@ | |||
| Programs which depend upon \tcode{sizeof('x')} are probably rare. | |||
|
|
|||
| Subclause \ref{lex.string}: | |||
| \change String literals made const\\ | |||
| \change String literals made const.\\ | |||
There was a problem hiding this comment.
Below you style const as code; should it be code here, too? When do you use which style?
There was a problem hiding this comment.
My patch does not change the "const" \tcode style, it just adds periods etc. (At least I hope so.) I believe we have a separate issue for const vs. \tcode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently end the 'Changes' phrase with a period.
Add missing newlines.
Remove spurious 'Rationale' item.
Fix typos.
Fixes #214.