[dcl.decl] Turn very large footnote into ordinary note. #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
reviewed
Nov 26, 2016
| T D1; T D2; ... T Dn; | ||
| \end{codeblock} | ||
| where \tcode{T} is a \grammarterm{decl-specifier-seq} | ||
| and each \tcode{Di} is an \grammarterm{init-declarator}. | ||
| An exception occurs when a name introduced by one of the |
There was a problem hiding this comment.
If we're promoting this to a note, the bar for clarity and correctness is a little higher, and we shouldn't be saying "an exception occurs when" unless we mean that an exception is thrown. How about "One exception is when" here and "Another exception is when" below?
There was a problem hiding this comment.
Sounds good! Patch amended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This footnote
Some or all of these issues might be addressable individually, but the easiest way to fix them all in one fell swoop is to just turn this weird creature into a normal note that needs no special treatment or commands. :)
(I tried diffpdf's other comparison modes, but they produced even less useful coloring.)