Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application of LWG 2567 missed a few bool(Bi::value) casts #1132

Closed
timsong-cpp opened this issue Nov 26, 2016 · 1 comment
Closed

Application of LWG 2567 missed a few bool(Bi::value) casts #1132

timsong-cpp opened this issue Nov 26, 2016 · 1 comment

Comments

@timsong-cpp
Copy link
Contributor

timsong-cpp commented Nov 26, 2016 •
edited

The P/R says "for which bool(Bi::value) is false" etc., not "for which Bi::value == false". The cast is important as Bi::value could be of a user-defined type.
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 26, 2016

Yes, looks like you're right. I missed that when I reviewed the commit.

tkoeppe added a commit to tkoeppe/draft that referenced this issue Nov 26, 2016
@tkoeppe
[meta.logical] Fix application of LWG 2567 and add further explicit b…
c9c19a6 
…oolean conversions editorially.

Fixes cplusplus#1132.
@tkoeppe tkoeppe mentioned this issue Nov 26, 2016
Merged
tkoeppe added a commit that referenced this issue Nov 27, 2016
@tkoeppe
[meta.logical] Fix application of LWG 2567 and add further explicit b…
22c396b 
…oolean conversions editorially. (#1133)

Fixes #1132.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkoeppe @timsong-cpp