Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/(possibly cv-qualified)/\\cv{}~/ and allied changes. #1142

Merged
merged 1 commit into from Dec 14, 2016

Conversation

W-E-Brown
Copy link
Contributor

As previously discussed with the Project Editor, changed (mainly in <type_traits> tables but also in other places) occurrences of "(possibly cv-qualified)" followed by a type (usually void, but also occasionally bool, etc.) by the \cv{} macro. To avoid a line break after \cv{}, replaced the space by a tilde (i.e., by a non-breaking space).

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 29, 2016

@jensmaurer: Could you please take a look? Weren't you working in that field recently?

@@ -401,7 +401,7 @@
type \tcode{T} (Clause~\ref{conv}, \ref{expr.type.conv},
\ref{expr.dynamic.cast}, \ref{expr.static.cast}, \ref{expr.cast}), or
\item an expression that is not a null pointer constant, and has type
other than \cv{} \tcode{void*}, is converted to the type pointer to \tcode{T}
other than \cv{}~\tcode{void*}, is converted to the type pointer to \tcode{T}
or reference to \tcode{T} using a standard conversion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general (not a comment on this change), instead of "cv void *", I'd like to see phrasing such as "pointer to cv void" (in double quotes). The latter is the "official" type language introduced in 8.3, and we should use it, in particular when we do not-quite-C++ things such as \cv with it.

@jensmaurer
Copy link
Member

jensmaurer commented Nov 29, 2016

This looks good to me, i.e. this patch does what the description above says. The bulk of the changes is adding non-breaking spaces between \cv{} and the stuff that follows; this has the chance of introducing more overfull/underfull hboxes, but we can fix those later.

It would be good to get this in sooner rather than later, because the changes overlap with the changes planned for #1139.

@zygoloid: Please merge this after confirming the general plan is ok.

@W-E-Brown
Copy link
Contributor Author

Rebased. Anything else for me to do?

@W-E-Brown
Copy link
Contributor Author

Ping.

@zygoloid zygoloid merged commit 64e5cff into cplusplus:master Dec 14, 2016
@W-E-Brown W-E-Brown deleted the cv branch December 14, 2016 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants