Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containers] Add a space after "Requires:" #1146

Closed
wants to merge 1 commit into from

Conversation

jlaire
Copy link

@jlaire jlaire commented Nov 29, 2016

No description provided.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 29, 2016

Can you please attach a screenshot of the diffpdf?

@jlaire
Copy link
Author

jlaire commented Nov 29, 2016

I will try to do that later today. I just noticed that the spacing looks bad and all other uses of \requires inside tables are followed by the escaped space.

@jwakely
Copy link
Member

jwakely commented Nov 29, 2016

Where is the spacing bad? I see no changes from this change (visually, or using diffpdf), so it doesn't seem to have any effect.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 29, 2016

Indeed, since the macro uses xspace I expect there to not be an effect. I also don't see anything wrong with the status quo.

@jlaire
Copy link
Author

jlaire commented Nov 29, 2016

Darn, I was reading n4606.pdf. It's getting quite old compared to master.

@jlaire jlaire closed this Nov 29, 2016
@jlaire jlaire deleted the add-missing-space-in-tables branch November 29, 2016 20:48
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 29, 2016

@jlaire: the current working paper is n4618.pdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants