Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utilities] Use code font for named requirements #1151

Merged
merged 1 commit into from Dec 14, 2016

Conversation

jlaire
Copy link

@jlaire jlaire commented Nov 29, 2016

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 29, 2016

@jwakely: Looks like your area.

@jlaire
Copy link
Author

jlaire commented Nov 29, 2016

TrivialClock is similar, and it's always in code font. A global decision about what to do with these would be useful.

On the other hand, "Clock" in "Clock requirements" appears in normal font most of the time but in code font once.

@zygoloid
Copy link
Member

Named sets of requirements are usually formatted in code font. See [utility.requirements] for a bunch of examples, in addition to TrivialClock. UnaryTypeTrait, BinaryTypeTrait, and TransformationTrait are outliers here.

I would be fine with having a different typographical convention for them, but it should be applied consistently.

@jlaire
Copy link
Author

jlaire commented Nov 30, 2016

I'll update this PR to change them to code font for consistency tomorrow.

@jwakely
Copy link
Member

jwakely commented Nov 30, 2016

I agree these concept-ish terms should all be typographically distinct, and currently we do that with code font.

I think the one occurrence of "Clock" in code font is wrong, IMHO "Clock requirements" is more like "Associative container requirements" than a concept like "CopyConstructible". (Although it could be argued the other way, Lockable and TimedLockable are counterexamples.)

As #1154 says, BaseCharacteristic probably shouldn't be one of these terms, so don't change that.

@jwakely
Copy link
Member

jwakely commented Nov 30, 2016

And then there's "Allocator requirements" which is sometimes code font and sometimes not.

@jlaire jlaire force-pushed the remove-tcode-for-meta-concepts branch from 861a9c4 to 6c1b016 Compare December 5, 2016 15:13
@jlaire jlaire changed the title [utilities] Use normal font for UnaryTypeTrait [utilities] Use code font for named requirements Dec 5, 2016
@jlaire
Copy link
Author

jlaire commented Dec 5, 2016

I'm not sure if the \defn instances should have \tcode inside them, too.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 8, 2016

@jwakely: Are you waiting for some changes from the author here?

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 14, 2016

Can you please rebase this? I think we're ready to apply this.

@jlaire jlaire force-pushed the remove-tcode-for-meta-concepts branch from 6c1b016 to 619aa95 Compare December 14, 2016 18:28
@jlaire
Copy link
Author

jlaire commented Dec 14, 2016

Rebased. "Allocator requirements" and some others are still inconsistent like pointed out by @jwakely, but I don't have time to look into them at the moment. I think they can be done in a separate PR.

@tkoeppe tkoeppe merged commit 2de3d8a into cplusplus:master Dec 14, 2016
@jlaire jlaire deleted the remove-tcode-for-meta-concepts branch December 14, 2016 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants