Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments in code example in footnotes should be italic like elsewhere #1152

Closed
Eelis opened this issue Nov 29, 2016 · 5 comments
Closed

Comments in code example in footnotes should be italic like elsewhere #1152

Eelis opened this issue Nov 29, 2016 · 5 comments
Assignees
@jensmaurer

Comments

@Eelis
Copy link
Contributor

Eelis commented Nov 29, 2016

No description provided.

@jensmaurer jensmaurer changed the title [over.ics.user] Comments in code example in footnote 132 should be italic like elsewhere [over.best.ics] Comments in code example in footnote 132 should be italic like elsewhere Nov 30, 2016
@jensmaurer
Copy link
Member

This is 13.3.3.1p10.

My opinion: Move the footnote into a regular note and rephrase it substantially. The normative sentence after the footnote should also become part of the note. (It's redundant here.)

jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 30, 2016
@jensmaurer
[over.best.ics] Turn a rationalizing footnote into a note with an acc…
235c2a2 
…ompanying example.

Fixes cplusplus#1152.
@jensmaurer jensmaurer mentioned this issue Nov 30, 2016
Closed
@jensmaurer jensmaurer self-assigned this Nov 30, 2016
jensmaurer added a commit to jensmaurer/draft that referenced this issue Nov 30, 2016
@jensmaurer
[over.best.ics] Turn a rationalizing footnote into a note with an acc…
de090aa 
…ompanying example.

Fixes cplusplus#1152.
@Eelis
Copy link
Contributor Author

Eelis commented Dec 7, 2016

Spotted another one: http://eel.is/c++draft/over.match.best#footnote-133

@Eelis Eelis changed the title [over.best.ics] Comments in code example in footnote 132 should be italic like elsewhere Comments in code example in footnotes should be italic like elsewhere Dec 7, 2016
@jensmaurer
Copy link
Member

@Eelis: This is exactly the one this issue is talking about, and it's fixed by my proposed patch.

@jensmaurer
Copy link
Member

Fixed by #1232.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 14, 2016

(The problem with footnotes is that the listings environments don't work in them, so you don't get any of the magic features like text-front comments. Best to avoid footnotes that require commented code!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Eelis @tkoeppe @jensmaurer