[over.best.ics] Turn a rationalizing footnote into a note with an acc… #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
reviewed
Nov 30, 2016
| \tcode{f(B)} | ||
| is better than any of the sequences required to match | ||
| \tcode{f(A)}.}. | ||
| other user-defined conversion sequence. \begin{note} |
There was a problem hiding this comment.
What do you think of making the note+example a new paragraph? (You could then even nest the example inside the note if you prefer.)
There was a problem hiding this comment.
The note + example definitely belong to the "ambiguous conversion sequence" paragraph. The example highlights the entire preceding paragraph, not just the note, so nesting is not an option.
I could make the example (but not the note) a new paragraph. It seems we recently gravitate towards making long code examples separate paragraphs. Done.
Eelis
reviewed
Nov 30, 2016
| class C { C(B&); }; | ||
| B b; | ||
| int g(A); | ||
| int x = g(b); // error: selects g(A), but converting the argument is ambiguous (\ref{over.match.copy}) |
There was a problem hiding this comment.
Should g(A) have some \tcode here?
…ompanying example. Fixes cplusplus#1152.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ompanying example.
Fixes #1152.