Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[streambuf.virt.get] use half-open ranges in underflow effects #1157

Merged
merged 1 commit into from Feb 4, 2017
Merged

[streambuf.virt.get] use half-open ranges in underflow effects #1157

merged 1 commit into from Feb 4, 2017

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Nov 30, 2016

underflow1
underflow2

We should discuss this before merging, I'm ambivalent about it.

@jwakely jwakely mentioned this pull request Nov 30, 2016
Merged
@jensmaurer
Copy link
Member

Oh well. This seems to be a presentational improvement. Is that the only place in streambufs where we have that style of description? I wouldn't want to address only one of possibly N adjacent places.
[I still find this "backup sequence" stuff totally obtuse, but that's a different story.]

tkoeppe
tkoeppe reviewed Dec 7, 2016
View reviewed changes
Copy link
Contributor

@tkoeppe tkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwakely: Ping - a comma is required.

source/iostreams.tex
characters starting at
\tcode{gptr()},
characters in
\range{gptr()}{egptr()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shall retain the final comma here, otherwise the "otherwise" would subsume the next bullet!

@zygoloid
Copy link
Member

I like it. Looks good to merge once @tkoeppe's comment is addressed.

@jwakely
Copy link
Member Author

jwakely commented Dec 15, 2016

Rebased and added the comma.

@jwakely
Copy link
Member Author

jwakely commented Dec 15, 2016

I should probably also look at overflow in [streambuf.virt.put] which uses a similar style:

the the pptr() - pbase() characters beginning at pbase()

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 15, 2016

@jwakely: Yes, sounds good. We don't come past this section very often, so getting all the cleanup done in one go seems like a good idea

@zygoloid zygoloid merged commit 5a1d430 into cplusplus:master Feb 4, 2017
@zygoloid
Copy link
Member

zygoloid commented Feb 4, 2017

Taking this part for C++17; I'd rather get this in than wait for more cleanups to be added to it.

@jwakely jwakely deleted the underflow-ranges branch November 23, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jwakely @jensmaurer @zygoloid @tkoeppe