Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[re.regex]/3 regex_constants presentation #1163

Closed
jensmaurer opened this issue Dec 1, 2016 · 4 comments
Closed

[re.regex]/3 regex_constants presentation #1163

jensmaurer opened this issue Dec 1, 2016 · 4 comments
Assignees
@jensmaurer
Milestone
C++20 IS

Comments

@jensmaurer
Copy link
Member

Each constant takes up two lines. That's ugly.

We could squeeze each on a single line (with comfortable padding) if we used the flag_type alias for regex_constants::syntax_option_type.

Opinions?
@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 7, 2016

I like the idea of compressing the presentation, which is needlessly noisy at the moment.

@jwakely, @AlisdairM, do you think that would be in line with existing practice?

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Dec 13, 2016
@AlisdairM
Copy link
Contributor

makes sense to me too, but only if applied consistently through the clause, rather than cherry picking the list of constants in the class definition - we don't want to use two ways of saying the same thing.

@jwakely
Copy link
Member

jwakely commented Jan 16, 2017

Using flag_type might be the least noisy form.

@jensmaurer
Copy link
Member Author

Editorial meeting consensus: Apply flag_type to synopsis. Remove [re.regex.const]. Call out in the editor's report.

@jensmaurer jensmaurer added this to the C++20 milestone Mar 2, 2017
@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Mar 2, 2017
@jensmaurer jensmaurer self-assigned this Mar 25, 2018
@jensmaurer jensmaurer mentioned this issue Mar 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
C++20 IS
Development

No branches or pull requests
4 participants
@AlisdairM @jwakely @tkoeppe @jensmaurer