Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macros, styles] Make BNF vertical spacing like that of normal paragraphs #1170

Merged
merged 1 commit into from Feb 4, 2017

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Dec 3, 2016

Removes minpages; adds custom enumitem list.

BNF entries are now spaced like normal paragraphs. Individual paragraphs are kept on a single page by setting a high widow penalty.

It is now immaterial whether multiple nontermdefs are contained in a single bnf environment, or whether each def is in its own environment. Pages can break between elements, not within.

@tkoeppe tkoeppe force-pushed the style5 branch 2 times, most recently from 3ac1384 to 24601b1 Compare December 18, 2016 23:36
@jensmaurer
Copy link
Member

At least the resulting LaTeX looks a lot cleaner... Do you have before/after screenshots?

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Jan 13, 2017

I can make those, hang on.

…tom enumitem list for spacing.

BNF entries are now spaced like normal paragraphs. Individual paragraphs are kept on a single page by setting a high widow penalty.

It is now immaterial whether multiple nontermdefs are contained in a single bnf environment, or whether each def is in its own environment. Pages can break between elements, not within.
@tkoeppe
Copy link
Contributor Author

tkoeppe commented Jan 13, 2017

Here's a small example. The diffs are pervasive, which makes diffpdf not a great tool; I recommend building your own version and seeing for yourself. (Especially long grammars like in Clause 6 are interesting in the way the widow/orphan control works.)

image

@jensmaurer
Copy link
Member

Thanks. It seems this change is not harmful.

@zygoloid zygoloid merged commit 42578d9 into cplusplus:master Feb 4, 2017
@tkoeppe tkoeppe deleted the style5 branch February 4, 2017 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants