Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[strings, algorithms, diff] Replace 'routine' with 'function'. #1217

Merged
merged 1 commit into from Dec 14, 2016

Conversation

Eelis
Copy link
Contributor

@Eelis Eelis commented Dec 13, 2016

These are the only occurrences.

@jensmaurer
Copy link
Member

Looks good to me.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 14, 2016

@jensmaurer: Are you sure that "function" doesn't subtly introduce a more constrained notion than "routine"? I'd be happy to merge if you are confident that this is correct.

@Eelis
Copy link
Contributor Author

Eelis commented Dec 14, 2016

For fun, I searched for occurrences of "routine" in the C99 standard. Of the five I found, three appear as synonym for "function", one occurs in "objects referred to by interrupt service routines activated by the signal function" (which I guess refers to callback functions), and the fifth and most interesting one is:

A principal use of the sizeof operator is in communication with routines such as storage allocators and I/O systems.

Sounds old-timey to me, haven't heard of an I/O system referred to as a "routine" recently. :) But I guess that's the kind of less constrained notion you might have been thinking of. Feel free to close if that's what's intended. In that case, though, perhaps we ought to have a proper definition for the term?

@jensmaurer
Copy link
Member

@tkoeppe: "routine" is an undefined concept in C++. I've reviewed the patch again, and in all cases, we're directly talking about "functions" as C++ understands them. Mentioning a "routine" is just a colloquialism that crept in.

@tkoeppe tkoeppe merged commit b54f250 into cplusplus:master Dec 14, 2016
@Eelis Eelis deleted the routine branch December 14, 2016 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants