[any] Rename the ValueType template parameter to T. #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
reviewed
Dec 13, 2016
| template<class ValueType> | ||
| any(ValueType&& value); | ||
| template<class T> | ||
| any(T&& value); |
tkoeppe
reviewed
Dec 13, 2016
| template<class ValueType> | ||
| any& operator=(ValueType&& rhs); | ||
| template<class T> | ||
| any& operator=(T&& rhs); |
The parameter has a confusing name: It is not actually the value type contained in the 'any'. Where the new T clashes with an existing use of T, rename the latter to VT, since this is actually the value type of the 'any'. Fixes cplusplus#1202.
|
Done. |
Closed
lichray
added a commit
to lichray/draft
that referenced
this pull request
May 16, 2017
jwakely
pushed a commit
that referenced
this pull request
May 18, 2017
Restores the changes made by #1220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter has a confusing name: It is not actually the value type
contained in the 'any'.
Where the new T clashes with an existing use of T, rename the latter to VT,
since this is actually the value type of the 'any'.
Fixes #1202.