Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[over.built] Rework formatting of placeholders. #1237

Merged
merged 2 commits into from Dec 14, 2016

Conversation

jensmaurer
Copy link
Member

Fixes #1233.

Use \defn for definitions.
Use \placeholder for meta-variables used in describing
built-in candidate signatures.

Fixes cplusplus#1233.
\tcode{int}
and
\tcode{long}
but excluding e.g.
\tcode{char}).
Similarly, the term
\term{promoted arithmetic type}
\defn{promoted arithmetic type}
refers to floating types plus promoted integral types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This seems factually bad: Surely a "promoted arithmetic type" excludes float??)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. 5p11.4 says we don't promote "float" to "double" in expressions, in the way we promote char to int.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, I was thinking of the default argument promotions, not the arithmetic promotions.

@@ -3440,331 +3442,295 @@
\end{note}

\pnum
In the remainder of this section, \cvqual{vq} represents either
\tcode{volatile} or the absence of \tcode{volatile}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "or no cv qualifier"? Because currently it sounds like you could use "vq cv" to take an arbitrary cv-qualifier and constrain it to not include volatile.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reuse the "is either volatile or empty" wording from below?"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

\textit{T},
\textit{CV1},
\textit{CV2}),
(\tcode{\placeholder{C1}},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we could start thinking about subscripting, e.g. \tcode{\placeholder{C}}$_1$. But we can do that in a separate iteration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the subscripting is separate. And no, we want to use $\mcode{\placeholder{C}}_1$.
The thing inside the math environment should be a well-formed mathematical term. Just the subscript looks broken. (Maybe that rule helps LaTeX keep the spacing right.)

Copy link
Contributor

@tkoeppe tkoeppe Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with either. If you want a self-contained maths expression, use:

$\text{\tcode{\placeholder{X}}}_1$

etc.

Copy link
Member Author

@jensmaurer jensmaurer Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really like to introduce \mcode = \text{\tcode{...}} otherwise the LaTeX source gets unreadable. Later.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 14, 2016

Thanks!

Introduce \cvqual{vq} once in the introductory text of the section.
@jensmaurer
Copy link
Member Author

Updated.

@tkoeppe tkoeppe merged commit d63754b into cplusplus:master Dec 14, 2016
@jensmaurer jensmaurer deleted the b18 branch December 14, 2016 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants