[class.derived] Don't bother splitting last remark in note off into separate paragraph. #1240
Conversation
| @@ -147,16 +147,13 @@ | |||
| a derived class and its base class subobjects can be represented by a | |||
There was a problem hiding this comment.
Capitalize beginning of note.
| @@ -147,16 +147,13 @@ | |||
| a derived class and its base class subobjects can be represented by a | |||
| directed acyclic graph (DAG) where an arrow means ``directly derived | |||
| from''. A DAG of subobjects is often referred to as a ``subobject | |||
| lattice''. | |||
| lattice''. The arrows need not have a physical representation in memory. | |||
There was a problem hiding this comment.
I'd delete "The" and just say "Arrows need not...".
The association changes subtly here: the sentence is now about general graph theory, not about the figure. I think that's fine, though if you wanted to continue using this sentence to explain the figure, I'd add something like "Figure {X} shows {Y}; the arrows [in that figure] ..."
There was a problem hiding this comment.
Oh, sorry, I re-pushed before addressing this second review comment. I'll address this one too.
There was a problem hiding this comment.
I've moved the sentence about the arrows not being physical to directly after the sentence where the arrows are first introduced. The association does indeed change, but I agree that's fine, especially with this rearrangement.
Eelis
force-pushed
the
multiparamnotes
branch
2 times, most recently
from
da9491c
to
1f0eba7
Compare
| directed acyclic graph (DAG) where an arrow means ``directly derived | ||
| from''. A DAG of subobjects is often referred to as a ``subobject | ||
| lattice''. | ||
| from''. The arrows need not have a physical representation in memory. |
There was a problem hiding this comment.
I'd still change it to either "An arrow" or "Arrows", non?
There was a problem hiding this comment.
I guess I read it as "The arrows [in the DAG just described] need not ...", but I'm fine with "An arrow" or "Arrows", too :)
…eparate paragraph.
Eelis
force-pushed
the
multiparamnotes
branch
from
1f0eba7
to
346dee4
Compare
While I think this change is definitely merited on its own, its real significance is that it gets rid of the very last (as far as I can tell) multi-paragraph note in the document, thereby fixing half of #781.