[algorithms] Move non-modifying algorithms away #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK with this as-is, but I wonder if perhaps we should instead move all of [alg.partitions] into [alg.sorting], since partitioning is certainly a "related operation" of sorting. |
|
@jwakely: What's your opinion? |
|
I think it would be better to keep all the partition-related algos together, so if moving them under [alg.sorting] allows that then that seems good to me. |
The non-modifying operation is_partitioned doesn't fit into 'mutating sequence operations', and partitioning can be considered a weak sort. Fixes cplusplus#289.
|
Ok, I've moved [alg.partitions] into [alg.sorting], right after [alg.binary.search]. @jwakely, would you like to commit? |
CaseyCarter
added a commit
to CaseyCarter/draft
that referenced
this pull request
Jun 27, 2018
between the "binary_search" family and the "merge" family, to agree with the order of the detailed specifiations as reordered by cplusplus#1245. Fixes cplusplus#2218.
tkoeppe
pushed a commit
that referenced
this pull request
Jun 28, 2018
Move the synopsis for the "partitions" algorithms between the "binary_search" family and the "merge" family, to agree with the order of the detailed specifications as reordered by #1245.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from [alg.modifying.operations].
For is_partitioned, create a new subsection [alg.is_partitioned]
under [alg.nonmodifying].
For partition_point, create a new subsection [partition.point]
under [alg.binary.search].
Fixes #289.