New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mem.res.pool.overview] Implicit definition of terms #1258
Comments
@AlisdairM: Could you please take a look? |
I'll try to get to this in the next week or so - we will want a resolution for Kona. |
Acknowledging that this still needs attention - will try to pull together some feedback before leaving Kona Saturday night. |
Currently [mem.res.pool.options] has a cross-reference to [mem.res.monotonic.buffer] for the term "upstream memory resource" (added editorially in 7f9d7f7) which is completely bogus - there is no relationship between pool resources and monotonic buffers. The cross-reference should go to [mem.res.pool.overview], unfortunately that defines "upstream allocator" not "upstream memory resource" (which is also bogus - it's not an allocator, and the member function to obtain it is I suggest changing [mem.res.pool.overview] bullet (1.3) to define "upstream memory resource" and changing the reference in [mem.res.pool.options] to point there instead. [mem.res.pool.overview] defines pools and chunks with |
Here's a first stab at rewording this to define the terms properly, and change "upstream allocator" to "upstream memory resource": The
A Should the "Each call to |
I'd say yes: in our implementation,
|
@jwakely, I'd suggest you turn your proposal into a pull request; we might want to have an LWG check on the change. |
@zygoloid agrees on the proposed course of action. |
Update cross-reference in [mem.res.pool.options] to refer to [mem.res.pool.overview]. Fixes cplusplus#1258
Update cross-reference in [mem.res.pool.options] to refer to [mem.res.pool.overview]. Fixes cplusplus#1258
Update cross-reference in [mem.res.pool.options] to refer to [mem.res.pool.overview]. Fixes cplusplus#1258
The terms "pools", "chunks", upstream memory resource", "upstream allocator" are proclaimed to be defined here, but the phrasing doesn't actually say "A pool is ..." etc.
The text was updated successfully, but these errors were encountered: