Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[except] Replace \term and \textit #1286

Merged
merged 1 commit into from Jan 11, 2017
Merged

Conversation

jensmaurer
Copy link
Member

with \grammarterm or \defn/x as appropriate.

Also add an index entry.

Partially addresses #701.
Partially addresses #329.

goto lab;
} catch(...) { /* @\textit{handler 2}@ */ }
} catch(...) { /* @\textit{handler 1}@ */ }
} catch(...) { /* handler 2 */ }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments should be in code font here. Have a look at the new \commentellip macro I made for inspiration on how to achieve this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following text refers to "handler 1" and "handler 2" in italics. If we make the text in the comments \tcode, should I adjust the following text to \tcode, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the answer is "yes"...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main idea here is to make the /* appear as code. So it should be something like @\tcode{/* ... */}@ I think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

with \grammarterm or \defn/x as appropriate.

Also add an index entry.

Partially addresses cplusplus#701.
Partially addresses cplusplus#329.
@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 10, 2017

That's probably good. For good measure, could you please attach a diff screenshot?

@jensmaurer
Copy link
Member Author

For extra fun, this part has a page break in the middle...

page1
page2

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 11, 2017

Thanks. By the way, you should probably switch your diff mode to "appearance".

@tkoeppe tkoeppe merged commit 232e3f4 into cplusplus:master Jan 11, 2017
@jensmaurer jensmaurer deleted the b29 branch January 11, 2017 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants