Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sf.cmath] association of Greek math variables with parameters fails #1291

Closed
jensmaurer opened this issue Dec 23, 2016 · 3 comments
Closed
Assignees

Comments

@jensmaurer
Copy link
Member

We say, for example, where $nu$ is \tcode{nu} and $x$ is \tcode{x}, but we should say where $\nu$ is \tcode{nu} and $x$ is \tcode{x} so that we associate the Greek symbol used in the formula with the parameter, not some italics "nu" that appears nowhere else.

This affects the entire section.

@W-E-Brown
Copy link
Contributor

I don't know the origin of those phrases; they don't exist in N3060 (the FDIS for IS 29124), so I didn't write them. I agree that in their present form they're more confusing than helpful, so should be struck (my preference) or fixed.

(I'd rather see all these phrases gone because I find them redundant. In each case, the wording already previously states that we're calculating a function of the respective named function parameters. These phrases seem merely to repeat that information. Further, the purpose of the formulas is not to prescribe any algorithm, but to remove possible ambiguity regarding the functions' definition: the mathematics literature in several cases has multiple conflicting definitions that depend on the authors being consulted. Tying these pure definitions to the named parameters seems wrong.)

But yes, if we must keep them, then we must certainly correct these phrases.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 23, 2016

I agree. At first glance this would look like a simple editorial error to me by which the backslash was forgotten. If anyone could trace the origins of this to confirm that'd be great, but it definitely looks defective it its present form.

@W-E-Brown: I don't think the phrasing is entirely redundant, since the mathematical symbols are not a priori identified with any C++ identifiers, and I would much rather make such identifications explicitly than assume some kind of magic mapping. (We are sloppy with this in parts of [algorithms], too, but there that's often just down to tentative typography and not actual wording like here.)

@timsong-cpp
Copy link
Contributor

This was added in 9b18983.

@jensmaurer jensmaurer changed the title [sf.math] association of Greek math variables with parameters fails [sf.cmath] association of Greek math variables with parameters fails Dec 26, 2016
jensmaurer added a commit to jensmaurer/draft that referenced this issue Jan 1, 2017
@jensmaurer jensmaurer self-assigned this Jan 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants